Skip to content

fix: Use c-ares dns over evdns #56

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix: Use c-ares dns over evdns #56

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions Dockerfile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,7 @@ ARG PGBOUNCER_VERSION
# Install build dependencies.
RUN set -ex; \
apt-get update && apt-get upgrade -y; \
apt-get install -y --no-install-recommends curl make pkg-config libevent-dev build-essential libssl-dev libudns-dev openssl ; \
apt-get install -y --no-install-recommends curl make pkg-config libevent-dev build-essential libssl-dev libudns-dev libc-ares2 libc-ares-dev openssl ; \
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would we be able to remove libudns-dev from the list now that --with-udns is removed below?

apt-get purge -y --auto-remove ; \
rm -fr /tmp/* ; \
rm -rf /var/lib/apt/lists/*
Expand All @@ -32,7 +32,7 @@ RUN set -ex; \
RUN curl -sL http://www.pgbouncer.org/downloads/files/${PGBOUNCER_VERSION}/pgbouncer-${PGBOUNCER_VERSION}.tar.gz > pgbouncer.tar.gz ; \
tar xzf pgbouncer.tar.gz ; \
cd pgbouncer-${PGBOUNCER_VERSION} ; \
sh ./configure --without-cares --with-udns ; \
sh ./configure --with-cares; \
make


Expand All @@ -50,7 +50,7 @@ LABEL name="PgBouncer Container Images" \

RUN set -ex; \
apt-get update && apt-get upgrade -y; \
apt-get install -y libevent-dev libssl-dev libudns-dev libvshadow-utils findutils; \
apt-get install -y libevent-dev libssl-dev libudns-dev libvshadow-utils findutils libc-ares2 libc-ares-dev; \
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I assume you wouldn't want the -dev package in the final image?

apt-get -y install postgresql ; \
apt-get -y clean ; \
rm -rf /var/lib/apt/lists/*; \
Expand Down