Skip to content

Conversation

@GiniAppsPartners
Copy link
Contributor

Brief Summary of Changes

Add support for variables in text style.

What does this PR address?

  • GitHub issue (Add reference - #XX)
  • Refactoring
  • New feature
  • Bug fix
  • Adds more tests

Are tests included?

  • Yes
  • No

Reviewer, please note:

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I ran the full test suite before pushing the changes and all the tests pass.

Copy link
Contributor

@adimiz1 adimiz1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You added the ability to add text style via String, but what about adding it via expression?
You can see the implementation in the Java PR
Also I've added a new expression myself to the iOS SDK, you can see it in the branch:
feature/angle_expression

@adimiz1 adimiz1 self-requested a review April 3, 2022 05:13
@adimiz1 adimiz1 self-requested a review May 2, 2022 07:18
Copy link
Contributor

@adimiz1 adimiz1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi Alex
Please break this PR into two separate PR's
One for text style
And the other for expression normalization
Also please fix an comment I remarked on the expression normalization

guard !currentKey.isEmpty && !currentValue.isEmpty else {

guard !currentKey.isEmpty else {
if allSpaceAndOrDash {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A specific use case of regex expression should not impact the asString() function
This should be handled in the Regex expression and not outside of it

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I understood that this is the new requirements (according to Patriks tests)
Meaning if the value contains "allSpaceAndOrDash" then asString() should return "_" otherwise the tests fail.

@adimiz1 adimiz1 self-requested a review May 9, 2022 10:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants