Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Draining for TCP and PROXY #736

Closed

Conversation

maxmoehl
Copy link
Member

@maxmoehl maxmoehl commented Dec 3, 2024

No description provided.

@maxmoehl maxmoehl requested a review from CFN-CI as a code owner December 3, 2024 07:32
@maxmoehl maxmoehl requested a review from a team December 3, 2024 07:32
@maxmoehl maxmoehl force-pushed the maxmoehl/fix-draining branch from aa71f62 to ffc1b30 Compare December 3, 2024 07:39
@peanball peanball added the run-ci Allow this PR to be tested on Concourse label Dec 3, 2024
@maxmoehl
Copy link
Member Author

maxmoehl commented Dec 3, 2024

This is still lacking tests, I'm working on it.

@maxmoehl maxmoehl changed the title Maxmoehl/fix draining Fix Draining for TCP and PROXY Dec 4, 2024
@maxmoehl
Copy link
Member Author

maxmoehl commented Dec 4, 2024

The TCP part is a lot more work and I don't have the time to work on it right now. The broken PROXY protocol is an actual bug and I've opened #737 to address it. This will have to wait.

@maxmoehl maxmoehl closed this Dec 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
run-ci Allow this PR to be tested on Concourse
Projects
Development

Successfully merging this pull request may close these issues.

None yet

2 participants