Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix template generation for cloudstack #598

Merged

Conversation

mdimiceli
Copy link
Contributor

The templates are not correctly generated for cloudstack due to the migration from packr to go embed.

This change fixes the integration of "go embed" and removes the security-groups definition from the bbl-template.tf file like the others IaaS.

Copy link
Contributor

@ramonskie ramonskie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@rkoster rkoster merged commit 6bc5308 into cloudfoundry:main Mar 18, 2024
4 checks passed
@rkoster
Copy link

rkoster commented Mar 18, 2024

Thanks! @mdimiceli

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Development

Successfully merging this pull request may close these issues.

4 participants