feat: adding oauth token support #104
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I have added support for oauth_tokens, kindly review. Thanks! |
bgandon
requested changes
Mar 16, 2025
There was a problem hiding this comment.
Thanks for the contribution!
However, this is a fairly untested piece of code, as many errors will prevent it from working at all.
Please fix your code, test it, add automated test cases to the test suite, have the automated tests pass, and we'll be glad to accept it.
|
@bgandon Thanks for the detailed review. I have fixed the review comments, added tests and made sure everything passes. |
|
Could someone please review - thanks in advance! 😸 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.