Remove NodeJSCompatModule

[penalosa]

Fixes n/a

This will soon be removed in workerd, and was never fully supported for deployed Workers. As such, it's being entirely removed.

---

• Tests
  • TODO (before merge)
  • Tests included
  • Tests not necessary because: This passes the existing tests (with some modifications), which should be sufficient
• Wrangler E2E Tests CI Job required? (Use "e2e" label or ask maintainer to run separately)
  • I don't know
  • Required
  • Not required because:
• Public documentation
  • TODO (before merge)
  • Cloudflare docs PR(s):
  • Documentation not necessary because: never exposed to users
• Wrangler V3 Backport
  • TODO (before merge)
  • Wrangler PR: Backport #8666 to Wrangler v3 #8683
  • Not necessary because:

[changeset-bot]

🦋 Changeset detected

Latest commit: 825a3af

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 5 packages

Name	Type
miniflare	Patch
@cloudflare/vitest-pool-workers	Patch
wrangler	Patch
@cloudflare/pages-shared	Patch
@cloudflare/vite-plugin	Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

[github-actions]

A wrangler prerelease is available for testing. You can install this latest build in your project with:

npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/14104097440/npm-package-wrangler-8666

You can reference the automatically updated head of this PR with:

npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/prs/8666/npm-package-wrangler-8666

Or you can use npx with this latest build directly:

npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/14104097440/npm-package-wrangler-8666 dev path/to/script.js

Additional artifacts:

cloudflare-workers-bindings-extension:

wget https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/14104097440/npm-package-cloudflare-workers-bindings-extension-8666 -O ./cloudflare-workers-bindings-extension.0.0.0-v67b16d5af.vsix && code --install-extension ./cloudflare-workers-bindings-extension.0.0.0-v67b16d5af.vsix

create-cloudflare:

npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/14104097440/npm-package-create-cloudflare-8666 --no-auto-update

@cloudflare/kv-asset-handler:

npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/14104097440/npm-package-cloudflare-kv-asset-handler-8666

miniflare:

npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/14104097440/npm-package-miniflare-8666

@cloudflare/pages-shared:

npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/14104097440/npm-package-cloudflare-pages-shared-8666

@cloudflare/unenv-preset:

npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/14104097440/npm-package-cloudflare-unenv-preset-8666

@cloudflare/vite-plugin:

npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/14104097440/npm-package-cloudflare-vite-plugin-8666

@cloudflare/vitest-pool-workers:

npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/14104097440/npm-package-cloudflare-vitest-pool-workers-8666

@cloudflare/workers-editor-shared:

npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/14104097440/npm-package-cloudflare-workers-editor-shared-8666

@cloudflare/workers-shared:

npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/14104097440/npm-package-cloudflare-workers-shared-8666

@cloudflare/workflows-shared:

npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/14104097440/npm-package-cloudflare-workflows-shared-8666

Note that these links will no longer work once the GitHub Actions artifact expires.

---

[email protected] includes the following runtime dependencies:

Package	Constraint	Resolved
miniflare	workspace:*	4.20250321.0
workerd	1.20250321.0	1.20250321.0
workerd --version	1.20250321.0	2025-03-21

Please ensure constraints are pinned, and miniflare/workerd minor versions match.

[CarmenPopoviciu]

backport PR isn't created due to conflicts, so we'll need to create manually

[dario-piotrowicz]

Could someone clarify this logic here? why are we adding the flag if not present?

(PS: I'm not saying that I think it's wrong, I'd just really like to understand this bit 🙂)

[CarmenPopoviciu]

maybe @petebacondarwin ? This code path is very unfamiliar to me. Worth noting tho that this PR doesn't change the logic by which these flags are applied, so if the original code was doing something wrong I would rather fix that in a followup PR, rather than block this PR on it?