Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Version Packages #7803

Merged
merged 1 commit into from
Jan 17, 2025
Merged

Version Packages #7803

merged 1 commit into from
Jan 17, 2025

Conversation

workers-devprod
Copy link
Contributor

@workers-devprod workers-devprod commented Jan 16, 2025

This PR was opened by the Changesets release GitHub action. When you're ready to do a release, you can merge this and the packages will be published to npm automatically. If you're not ready to do a release yet, that's fine, whenever you add more changesets to main, this PR will be updated.

Releases

@cloudflare/[email protected]

Patch Changes

  • #7564 147ab7d Thanks @GregBrimble! - fix: Key the Early Hints cache entries off of the asset key rather than the request path

@cloudflare/[email protected]

Patch Changes

  • #7789 facb3ff Thanks @vicb! - refactor(unenv-preset): misc minor changes

    • Bump the Typescript dependency to ^5.7.3 as required by unbuild
    • Install a local version of @types/node (@types/node-unenv)
    • Add more details to the README

@cloudflare/[email protected]

Patch Changes

[email protected]

Patch Changes

  • #7804 16a9460 Thanks @vicb! - fix(wrangler): use require.resolve to resolve unenv path

@workers-devprod workers-devprod requested review from a team as code owners January 16, 2025 20:36
@workers-devprod workers-devprod added the skip-pr-description-validation Skip validation of the required PR description format label Jan 16, 2025
Copy link
Contributor

github-actions bot commented Jan 16, 2025

A wrangler prerelease is available for testing. You can install this latest build in your project with:

npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12828893060/npm-package-wrangler-7803

You can reference the automatically updated head of this PR with:

npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/prs/7803/npm-package-wrangler-7803

Or you can use npx with this latest build directly:

npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12828893060/npm-package-wrangler-7803 dev path/to/script.js
Additional artifacts:

cloudflare-workers-bindings-extension:

wget https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12828893060/npm-package-cloudflare-workers-bindings-extension-7803 -O ./cloudflare-workers-bindings-extension.0.0.0-v4b2222205.vsix && code --install-extension ./cloudflare-workers-bindings-extension.0.0.0-v4b2222205.vsix

create-cloudflare:

npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12828893060/npm-package-create-cloudflare-7803 --no-auto-update

@cloudflare/kv-asset-handler:

npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12828893060/npm-package-cloudflare-kv-asset-handler-7803

miniflare:

npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12828893060/npm-package-miniflare-7803

@cloudflare/pages-shared:

npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12828893060/npm-package-cloudflare-pages-shared-7803

@cloudflare/unenv-preset:

npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12828893060/npm-package-cloudflare-unenv-preset-7803

@cloudflare/vitest-pool-workers:

npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12828893060/npm-package-cloudflare-vitest-pool-workers-7803

@cloudflare/workers-editor-shared:

npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12828893060/npm-package-cloudflare-workers-editor-shared-7803

@cloudflare/workers-shared:

npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12828893060/npm-package-cloudflare-workers-shared-7803

@cloudflare/workflows-shared:

npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12828893060/npm-package-cloudflare-workflows-shared-7803

Note that these links will no longer work once the GitHub Actions artifact expires.


[email protected] includes the following runtime dependencies:

Package Constraint Resolved
miniflare workspace:* 3.20241230.2
workerd 1.20241230.0 1.20241230.0
workerd --version 1.20241230.0 2024-12-30

Please ensure constraints are pinned, and miniflare/workerd minor versions match.

@CarmenPopoviciu
Copy link
Contributor

The regression this release will fix was not caught by our C3 e2e tests, because these tests run against starter projects that depend on wrangler@latest and not whatever exists on the PR branch, or even main. This would apply for the current PR as well, so in order to get a bit more confidence that we are not introducing other regressions with these changes, I have put together a hack PR that changed the way C3 starter projects are created, and ensured that they are created with a dependency on wrangler@beta, which reflects wrangler on the main branch.

For testing purposes I have done 2 things:

  1. first, I set the wrangler version in the generated starter projects to [email protected]. This was the version that included a similar regression we fixed in previous release, that we knew broke the C3 e2e tests after release. The C3 e2e tests that were expected to fail, did indeed fail, for the same reasons as we saw previously. This confirmed to me that the [email protected] version was correctly applied, and that the changes of that draft PR were working.
Screenshot 2025-01-17 at 15 46 03 Screenshot 2025-01-17 at 15 46 27
  1. I then set the wrangler version in the generated starter projects to wrangler@beta. All tests that failed in the previous run were now successful, which gave me extra confidence that the changes of the current Version Packages PR did not break the existing e2e tests 🎉
Screenshot 2025-01-17 at 16 04 02 Screenshot 2025-01-17 at 16 04 21

I am therefore approving this PR and here's to no more regression y'all ♥️

@CarmenPopoviciu CarmenPopoviciu merged commit cca7885 into main Jan 17, 2025
35 checks passed
@CarmenPopoviciu CarmenPopoviciu deleted the changeset-release/main branch January 17, 2025 16:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
skip-pr-description-validation Skip validation of the required PR description format
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants