-
Notifications
You must be signed in to change notification settings - Fork 758
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix and update experimental Next.js template to work on @opennextjs/[email protected]
#7638
Conversation
🦋 Changeset detectedLatest commit: ea5ba02 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
packages/create-cloudflare/templates-experimental/next/templates/.gitignore
Show resolved
Hide resolved
A wrangler prerelease is available for testing. You can install this latest build in your project with: npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12517765304/npm-package-wrangler-7638 You can reference the automatically updated head of this PR with: npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/prs/7638/npm-package-wrangler-7638 Or you can use npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12517765304/npm-package-wrangler-7638 dev path/to/script.js Additional artifacts:wget https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12517765304/npm-package-cloudflare-workers-bindings-extension-7638 -O ./cloudflare-workers-bindings-extension.0.0.0-v4fda7eecd.vsix && code --install-extension ./cloudflare-workers-bindings-extension.0.0.0-v4fda7eecd.vsix npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12517765304/npm-package-create-cloudflare-7638 --no-auto-update npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12517765304/npm-package-cloudflare-kv-asset-handler-7638 npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12517765304/npm-package-miniflare-7638 npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12517765304/npm-package-cloudflare-pages-shared-7638 npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12517765304/npm-package-cloudflare-unenv-preset-7638 npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12517765304/npm-package-cloudflare-vitest-pool-workers-7638 npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12517765304/npm-package-cloudflare-workers-editor-shared-7638 npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12517765304/npm-package-cloudflare-workers-shared-7638 npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12517765304/npm-package-cloudflare-workflows-shared-7638 Note that these links will no longer work once the GitHub Actions artifact expires.
Please ensure constraints are pinned, and |
packages/create-cloudflare/templates-experimental/next/templates/.gitignore
Show resolved
Hide resolved
packages/create-cloudflare/templates-experimental/next/templates/.gitignore
Show resolved
Hide resolved
37fecf2
to
e7f4eea
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks
Could you please also add a .dev.vars, using https://github.com/flarelabs-net/workers-next/blob/main/.dev.vars.example as a template
packages/create-cloudflare/templates-experimental/next/templates/.gitignore
Show resolved
Hide resolved
packages/create-cloudflare/templates-experimental/next/templates/wrangler.toml
Outdated
Show resolved
Hide resolved
…js/[email protected]` fix incorrect main
…js/[email protected]` include `.dev.vars` template file
…js/[email protected]` add missing newline
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks.
Maybe create an issue on https://github.com/opennextjs/docs to update the docs when this PR is released to c3
This is the Next.js guide that uses the open-next adapter: https://developers.cloudflare.com/workers/frameworks/framework-guides/nextjs/ I don't think there's anything in the changes I'm making that needs updating there (otherwise I'd do open a PR right away and merge it after the C3 release) |
…js/[email protected]` skip bun and yarn experimental e2es
We need to update that which is repeated multiple times to use the c3 experimental template |
ah ok, sorry I thought we were talking about the Cloudflare docs 👍 (I missed that you were actually linking to the opennextjs docs 🤦) |
Merging this PR as the only failing tests are e2es (both experimental and not) running nuxt using yarn under ubuntu and:
I've opened a followup PR to address the Nuxt issue: #7648 |
…[email protected]` (#7638) * update the experimental Next.js template to work on `@opennextjs/[email protected]` * include `.dev.vars` template file * skip bun and yarn experimental e2es
Changes made in
@opennextjs/[email protected]
haven't been updated in the C3 experimental template causing C3 to currently create broken open-next applications, this PR is addressing that plus some other small minor related updates.@opennextjs/[email protected]
cloudflare-docs#18946