Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(create-cloudflare): opennextjs-cloudflare binary #7632

Closed
wants to merge 2 commits into from

Conversation

Cherry
Copy link
Contributor

@Cherry Cherry commented Dec 24, 2024

Fixes #7631

opennextjs/opennextjs-cloudflare#166 changed the binary name here. This fixes that.


  • Tests
    • TODO (before merge)
    • Tests included
    • Tests not necessary because: no functional changes
  • E2E Tests CI Job required? (Use "e2e" label or ask maintainer to run separately)
    • I don't know
    • Required
    • Not required because: no functional changes
  • Public documentation
    • TODO (before merge)
    • Cloudflare docs PR(s):
    • Documentation not necessary because: no functional changes

@Cherry Cherry requested review from a team as code owners December 24, 2024 19:02
Copy link

changeset-bot bot commented Dec 24, 2024

🦋 Changeset detected

Latest commit: 0e061a7

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
create-cloudflare Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@vicb
Copy link
Contributor

vicb commented Dec 26, 2024

As explained on the issue this fix is not the right one.

The template still match 0.2.x so the correct fix is to pin to that version.

@vicb vicb closed this Dec 26, 2024
@Cherry
Copy link
Contributor Author

Cherry commented Dec 26, 2024

I see, thanks.

In that case, I would recommend that all of these templates are version pinned moving forward to avoid issues like that.

This PR and issue was created in direct response to a user in Discord encountering hard to debug issues with this template.

@vicb
Copy link
Contributor

vicb commented Dec 26, 2024

In that case, I would recommend that all of these templates are version pinned moving forward to avoid issues like that.

+1 to that.

2 things that were not ideal here:

  • The issue was detected (failing CI) last Friday are c3 releases are paused during vacation
  • OpenNext/cloudflare is pre 1.0 and minor releases can break

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

🐛 BUG: create-cloudflare with opennextjs-cloudflare deploy script error
2 participants