-
Notifications
You must be signed in to change notification settings - Fork 749
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Warning about browser rendering when running locally #7533
base: main
Are you sure you want to change the base?
Add Warning about browser rendering when running locally #7533
Conversation
🦋 Changeset detectedLatest commit: 257a2b3 The changes in this PR will be included in the next version bump. This PR includes changesets to release 2 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
9f810da
to
c09902c
Compare
A wrangler prerelease is available for testing. You can install this latest build in your project with: npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12371058411/npm-package-wrangler-7533 You can reference the automatically updated head of this PR with: npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/prs/7533/npm-package-wrangler-7533 Or you can use npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12371058411/npm-package-wrangler-7533 dev path/to/script.js Additional artifacts:wget https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12371058411/npm-package-cloudflare-workers-bindings-extension-7533 -O ./cloudflare-workers-bindings-extension.0.0.0-v03c8f6dda.vsix && code --install-extension ./cloudflare-workers-bindings-extension.0.0.0-v03c8f6dda.vsix npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12371058411/npm-package-create-cloudflare-7533 --no-auto-update npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12371058411/npm-package-cloudflare-kv-asset-handler-7533 npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12371058411/npm-package-miniflare-7533 npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12371058411/npm-package-cloudflare-pages-shared-7533 npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12371058411/npm-package-cloudflare-vitest-pool-workers-7533 npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12371058411/npm-package-cloudflare-workers-editor-shared-7533 npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12371058411/npm-package-cloudflare-workers-shared-7533 npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12371058411/npm-package-cloudflare-workflows-shared-7533 Note that these links will no longer work once the GitHub Actions artifact expires.
Please ensure constraints are pinned, and |
@@ -951,6 +951,10 @@ export async function buildMiniflareOptions( | |||
} | |||
} | |||
|
|||
if (config.bindings.browser) { | |||
logger.warn("Browser render is not supported locally use `--remote`"); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
logger.warn("Browser render is not supported locally use `--remote`"); | |
logger.warn("Browser render is not supported locally. Please use `wrangler dev --remote` instead."); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why is this handled in miniflare.ts
? This type of warnings and stdout logging is generally managed at command handler level. Which command(s) is/are targeted by this warning?
c09902c
to
257a2b3
Compare
We usually test for this kind of stdout. See here for example. So we would def like to cover this warning as well by a unit test 🙏 |
Fixes #BRAPI-120.
Add warning when running browser rendering locally