SQC-352 SQC-353 Create cert upload command for client side mtls certificate/CA chain certificates #7466

Ltadrian · 2024-12-05T23:25:05Z

Create cert upload command for client side mtls certificate/CA chain certificates

Fixes #[insert GH or internal issue link(s)].

Allows the capability to upload custom CA certificates and client mTLS certificates. This is a lot similar to mtls-certificate command but our goal was to avoid confusion with workers support. This custom CA certificates upload is not a supported binding for workers. It will be available as a Hyperdrive binding very soon.

Internal JIRA
SQC-352
SQC-353

Tests
- TODO (before merge)
- Tests included
- Tests not necessary because:
E2E Tests CI Job required? (Use "e2e" label or ask maintainer to run separately)
- I don't know
- Required
- Not required because: (not required on this PR, run here: Run CI on behalf of #7466 #7779)
Public documentation
- TODO (before merge) : Currently blocked need access to cloudflare docs github repo. Ready to push branch and open PR
- Cloudflare docs PR(s): SQC-352 SQC-353 create cert command documantion for mtls/CA cert chai… cloudflare-docs#19205
- Documentation not necessary because:

changeset-bot · 2024-12-05T23:25:09Z

🦋 Changeset detected

Latest commit: c396657

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 2 packages

Name	Type
wrangler	Minor
@cloudflare/vitest-pool-workers	Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

packages/wrangler/src/cert/cli.ts

packages/wrangler/src/__tests__/cert.test.ts

lrapoport-cf · 2024-12-09T14:53:33Z

hi @Ltadrian :) we recently introduced a new createCommand utility to be used when new commands are being added. can you please review https://github.com/cloudflare/workers-sdk/blob/main/packages/wrangler/CONTRIBUTING.md and update this PR accordingly? thank you!

Ltadrian · 2024-12-10T19:05:55Z

hi @Ltadrian :) we recently introduced a new createCommand utility to be used when new commands are being added. can you please review https://github.com/cloudflare/workers-sdk/blob/main/packages/wrangler/CONTRIBUTING.md and update this PR accordingly? thank you!

this has been updated now, thank you 😄

github-actions · 2024-12-31T17:57:33Z

A wrangler prerelease is available for testing. You can install this latest build in your project with:

npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12800697590/npm-package-wrangler-7466

You can reference the automatically updated head of this PR with:

npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/prs/7466/npm-package-wrangler-7466

Or you can use npx with this latest build directly:

npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12800697590/npm-package-wrangler-7466 dev path/to/script.js

Additional artifacts:

cloudflare-workers-bindings-extension:

wget https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12800697590/npm-package-cloudflare-workers-bindings-extension-7466 -O ./cloudflare-workers-bindings-extension.0.0.0-vdf2e07461.vsix && code --install-extension ./cloudflare-workers-bindings-extension.0.0.0-vdf2e07461.vsix

create-cloudflare:

npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12800697590/npm-package-create-cloudflare-7466 --no-auto-update

@cloudflare/kv-asset-handler:

npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12800697590/npm-package-cloudflare-kv-asset-handler-7466

miniflare:

npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12800697590/npm-package-miniflare-7466

@cloudflare/pages-shared:

npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12800697590/npm-package-cloudflare-pages-shared-7466

@cloudflare/unenv-preset:

npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12800697590/npm-package-cloudflare-unenv-preset-7466

@cloudflare/vitest-pool-workers:

npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12800697590/npm-package-cloudflare-vitest-pool-workers-7466

@cloudflare/workers-editor-shared:

npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12800697590/npm-package-cloudflare-workers-editor-shared-7466

@cloudflare/workers-shared:

npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12800697590/npm-package-cloudflare-workers-shared-7466

@cloudflare/workflows-shared:

npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12800697590/npm-package-cloudflare-workflows-shared-7466

Note that these links will no longer work once the GitHub Actions artifact expires.

[email protected] includes the following runtime dependencies:

Package	Constraint	Resolved
`miniflare`	workspace:*	3.20241230.2
`workerd`	1.20241230.0	1.20241230.0
`workerd --version`	1.20241230.0	2024-12-30

Please ensure constraints are pinned, and miniflare/workerd minor versions match.

emily-shen

would also be great to add some e2e tests :)

packages/wrangler/src/__tests__/cert.test.ts

.changeset/hip-cameras-yawn.md

packages/wrangler/src/cert/cert.ts

emily-shen · 2025-01-02T13:26:06Z

packages/wrangler/src/__tests__/cert.test.ts

+							typeof certs === "undefined"
+								? [
+										{
+											id: "1234",
+											name: "cert one",
+											certificates: "BEGIN CERTIFICATE...",
+											issuer: "example.com...",
+											uploaded_on: now.toISOString(),
+											expires_on: oneYearLater.toISOString(),
+										},
+										{
+											id: "5678",
+											name: "cert two",
+											certificates: "BEGIN CERTIFICATE...",
+											issuer: "example.com...",
+											uploaded_on: now.toISOString(),
+											expires_on: oneYearLater.toISOString(),
+										},
+									]
+								: certs,


you can do
certs ?? [... whatever you want to return if undefined]

packages/wrangler/src/cert/cert.ts

packages/wrangler/src/api/mtls-certificate.ts

packages/wrangler/src/cert/cert.ts

Ltadrian · 2025-01-02T17:42:17Z

would also be great to add some e2e tests :)

is that required?

emily-shen · 2025-01-03T11:53:46Z

would also be great to add some e2e tests :)

is that required?

yes, all new commands/features should have some happy-path e2e's before release :)

emily-shen · 2025-01-14T11:51:07Z

packages/wrangler/e2e/cert.test.ts

is it possible to generate a new cert and key each time? Just concerned about simultaneous CI runs interfering with each other.

Other than that, lgtm :))

this has been updated to generate certs

mtlemilio

Minor observations.

packages/wrangler/src/api/mtls-certificate.ts

packages/wrangler/src/cert/cert.ts

…ficates and ca chain certificates

Ltadrian requested a review from a team as a code owner December 5, 2024 23:25

mtlemilio reviewed Dec 6, 2024

View reviewed changes

packages/wrangler/src/cert/cli.ts Outdated Show resolved Hide resolved

packages/wrangler/src/__tests__/cert.test.ts Outdated Show resolved Hide resolved

Ltadrian force-pushed the ltadrian/cert-upload-mtls branch 4 times, most recently from 15327ba to 03af501 Compare December 10, 2024 18:58

Ltadrian force-pushed the ltadrian/cert-upload-mtls branch 4 times, most recently from e3d8b3d to 4450a1b Compare December 31, 2024 16:02

emily-shen added the e2e Run e2e tests on a PR label Jan 2, 2025

emily-shen requested changes Jan 2, 2025

View reviewed changes

Ltadrian force-pushed the ltadrian/cert-upload-mtls branch 2 times, most recently from 4f0a3b6 to 9356364 Compare January 2, 2025 17:35

emily-shen removed the e2e Run e2e tests on a PR label Jan 3, 2025

workers-devprod mentioned this pull request Jan 3, 2025

Run CI on behalf of #7466 #7661

Closed

Ltadrian force-pushed the ltadrian/cert-upload-mtls branch from 9356364 to 44fbd6f Compare January 14, 2025 03:28

workers-devprod added the e2e Run e2e tests on a PR label Jan 14, 2025

Ltadrian force-pushed the ltadrian/cert-upload-mtls branch 2 times, most recently from 6b67e53 to 9c7342b Compare January 14, 2025 03:52

emily-shen removed the e2e Run e2e tests on a PR label Jan 14, 2025

emily-shen reviewed Jan 14, 2025

View reviewed changes

workers-devprod mentioned this pull request Jan 14, 2025

Run CI on behalf of #7466 #7758

Closed

Ltadrian force-pushed the ltadrian/cert-upload-mtls branch from 9c7342b to 545288b Compare January 14, 2025 17:54

workers-devprod added the e2e Run e2e tests on a PR label Jan 14, 2025

workers-devprod mentioned this pull request Jan 15, 2025

Run CI on behalf of #7466 #7779

Closed

emily-shen removed the e2e Run e2e tests on a PR label Jan 15, 2025

Ltadrian force-pushed the ltadrian/cert-upload-mtls branch from 545288b to 0b9120a Compare January 15, 2025 15:46

workers-devprod added the e2e Run e2e tests on a PR label Jan 15, 2025

mtlemilio approved these changes Jan 15, 2025

View reviewed changes

packages/wrangler/src/api/mtls-certificate.ts Show resolved Hide resolved

packages/wrangler/src/cert/cert.ts Outdated Show resolved Hide resolved

packages/wrangler/src/cert/cert.ts Show resolved Hide resolved

SQC-352 SQC-353 Create cert upload command for client side mtls certi…

c396657

…ficates and ca chain certificates

Ltadrian force-pushed the ltadrian/cert-upload-mtls branch from 0b9120a to c396657 Compare January 16, 2025 02:10

workers-devprod mentioned this pull request Jan 16, 2025

Run CI on behalf of #7466 #7794

Draft

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

SQC-352 SQC-353 Create cert upload command for client side mtls certificate/CA chain certificates #7466

SQC-352 SQC-353 Create cert upload command for client side mtls certificate/CA chain certificates #7466

Ltadrian commented Dec 5, 2024 •

edited by emily-shen

Loading

changeset-bot bot commented Dec 5, 2024 •

edited

Loading

lrapoport-cf commented Dec 9, 2024

Ltadrian commented Dec 10, 2024

github-actions bot commented Dec 31, 2024 •

edited

Loading

emily-shen left a comment

emily-shen Jan 2, 2025

Ltadrian commented Jan 2, 2025

emily-shen commented Jan 3, 2025

emily-shen Jan 14, 2025 •

edited

Loading

Ltadrian Jan 14, 2025

mtlemilio left a comment

SQC-352 SQC-353 Create cert upload command for client side mtls certificate/CA chain certificates #7466

Are you sure you want to change the base?

SQC-352 SQC-353 Create cert upload command for client side mtls certificate/CA chain certificates #7466

Conversation

Ltadrian commented Dec 5, 2024 • edited by emily-shen Loading

changeset-bot bot commented Dec 5, 2024 • edited Loading

🦋 Changeset detected

lrapoport-cf commented Dec 9, 2024

Ltadrian commented Dec 10, 2024

github-actions bot commented Dec 31, 2024 • edited Loading

emily-shen left a comment

Choose a reason for hiding this comment

emily-shen Jan 2, 2025

Choose a reason for hiding this comment

Ltadrian commented Jan 2, 2025

emily-shen commented Jan 3, 2025

emily-shen Jan 14, 2025 • edited Loading

Choose a reason for hiding this comment

Ltadrian Jan 14, 2025

Choose a reason for hiding this comment

mtlemilio left a comment

Choose a reason for hiding this comment

Ltadrian commented Dec 5, 2024 •

edited by emily-shen

Loading

changeset-bot bot commented Dec 5, 2024 •

edited

Loading

github-actions bot commented Dec 31, 2024 •

edited

Loading

emily-shen Jan 14, 2025 •

edited

Loading