Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wrangler v4 #7334

Open
wants to merge 9 commits into
base: main
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/funny-pets-punch.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
"wrangler": major
---

Use `--local` by default for KV & R2
7 changes: 7 additions & 0 deletions .changeset/itchy-walls-reply.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,7 @@
---
"wrangler": major
---

chore: remove deprecated `getBindingsProxy`

remove the deprecated `getBindingsProxy` utility which has been replaced with `getPlatformProxy`
16 changes: 16 additions & 0 deletions .changeset/major-remove-args-config.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,16 @@
---
"wrangler": major
---

Remove the deprecated `--format` argument on `wrangler deploy` and `wrangler dev`.

Remove deprecated config fields:

- `type`
- `webpack_config`
- `miniflare`
- `build.upload`
- `zone_id`
- `usage_model`
- `experimental_services`
- `kv-namespaces`
11 changes: 11 additions & 0 deletions .changeset/major-remove-d1-backups.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,11 @@
---
"wrangler": major
---

Remove `wrangler d1 backups`

BREAKING CHANGE: This change removes `wrangler d1 backups`, a set of alpha-only commands that would allow folks to interact with backups of their D1 alpha DBs.

For production D1 DBs, you can restore previous versions of your database with `wrangler d1 time-travel` and export it at any time with `wrangler d1 export`.

Closes #7470
9 changes: 9 additions & 0 deletions .changeset/major-remove-d1-deprecated-batch-size.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,9 @@
---
"wrangler": major
---

Remove `--batch-size` as an option for `wrangler d1 execute` and `wrangler d1 migrations apply`

BREAKING CHANGE: This change removes the deprecated `--batch-size` flag, as it is no longer necessary to decrease the number of queries wrangler sends to D1.

Closes #7470
11 changes: 11 additions & 0 deletions .changeset/major-remove-d1-migrations-alpha.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,11 @@
---
"wrangler": major
---

Remove alpha support from `wrangler d1 migrations apply`

BREAKING CHANGE: This change removes code that would take a backup of D1 alpha databases before proceeding with applying a migration.

We can remove this code as alpha DBs have not accepted queries in months.

Closes #7470
5 changes: 5 additions & 0 deletions .changeset/major-remove-generate.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
"wrangler": major
---

Remove the deprecated `wrangler generate` command. Instead, use the C3 CLI to create new projects: https://developers.cloudflare.com/pages/get-started/c3/
5 changes: 5 additions & 0 deletions .changeset/major-remove-init.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
"wrangler": major
---

Remove the deprecated `wrangler init --no-delegate-c3` command. `wrangler init` is still available, but will always delegate to [C3](https://developers.cloudflare.com/pages/get-started/c3/).
5 changes: 5 additions & 0 deletions .changeset/major-remove-legacy-assets.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
"wrangler": major
---

Remove legacy assets
17 changes: 17 additions & 0 deletions .changeset/major-remove-publish.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,17 @@
---
"wrangler": major
---

Remove the deprecated `wrangler publish` command. Instead, use `wrangler deploy`, which takes exactly the same arguments.

Remove the following deprecated commands:

- `wrangler config`
- `wrangler preview`
- `wrangler route`
- `wrangler subdomain`

Remove the following deprecated command aliases:

- `wrangler secret:*`
- `wrangler kv:*`
5 changes: 5 additions & 0 deletions .changeset/major-remove-version.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
"wrangler": major
---

Remove the deprecated `wrangler version` command. Instead, use `wrangler --version` to check the current version of Wrangler.
8 changes: 8 additions & 0 deletions .changeset/node-compat-v4.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,8 @@
---
"wrangler": major
"miniflare": major
---

The `--node-compat` flag and `node_compat` config properties are no longer supported as of Wrangler v4. Instead, use the `nodejs_compat` compatibility flag. This includes the functionality from legacy `node_compat` polyfills and natively implemented Node.js APIs. See https://developers.cloudflare.com/workers/runtime-apis/nodejs for more information.

If you need to replicate the behaviour of the legacy `node_compat` feature, refer to https://developers.cloudflare.com/workers/wrangler/migration/update-v3-to-v4/ for a detailed guide.
178 changes: 178 additions & 0 deletions .changeset/proud-otters-bow.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,178 @@
---
"@cloudflare/vitest-pool-workers": minor
"wrangler": major
---

chore: update esbuild

This patch updates esbuild from 0.17.19 to 0.24.0. That's a big bump! Lots has gone into esbuild since May '23. All the details are available at https://github.com/evanw/esbuild/blob/main/CHANGELOG.md / https://github.com/evanw/esbuild/blob/main/CHANGELOG-2023.md.

- We now support all modern JavasScript/TypeScript features suported by esbuild (as of September 2024). New additions include standard decorators, auto-accessors, and the `using` syntax.

- 0.18 introduced wider support for configuration specified via `tsconfig.json` https://github.com/evanw/esbuild/issues/3019. After observing the (lack of) any actual broken code over the last year for this release, we feel comfortable releasing this without considering it a breaking change.

- 0.19.3 introduced support for import attributes

```js
import stuff from './stuff.json' with { type: 'json' }
```

While we don't currently expose the esbuild configuration for developers to add their own plugins to customise how modules with import attributes are bundled, we may introduce new "types" ourselves in the future.

- 0.19.0 introduced support for wildcard imports. Specifics here (https://github.com/evanw/esbuild/blob/main/CHANGELOG-2023.md#0190). tl;dr -

- These 2 patterns will bundle all files that match the glob pattern into a single file.

```js
const json1 = await import("./data/" + kind + ".json");
```

```js
const json2 = await import(`./data/${kind}.json`);
```

- This pattern will NOT bundle any matching patterns:
```js
const path = "./data/" + kind + ".js";
const json2 = await import(path);
```
You can use `find_additional_modules` to bundle any additional modules that are not referenced in the code but are required by the project.

Now, this MAY be a breaking change for some. Specifically, if you were previously using the pattern (that will now include all files matching the glob pattern in the bundle), BUT `find_additional_modules` was NOT configured to include some files, those files would now be included in the bundle. For example, consider this code:

```js
// src/index.js
export default {
async fetch() {
const url = new URL(request.url);
const name = url.pathname;
const value = (await import("." + name)).default;
return new Response(value);
},
};
```

Imagine if in that folder, you had these 3 files:

```js
// src/one.js
export default "one";
```

```js
// src/two.js
export default "two";
```

```js
// src/hidden/secret.js
export default "do not share this secret";
```

And your `wrangler.toml` was:

```toml
name = "my-worker"
main = "src/index.js
```

Before this update:

1. A request to anything but `http://localhost:8787/` would error. For example, a request to `http://localhost:8787/one.js` would error with _No such module "one.js"._

2. Let's configure `wrangler.toml` to include all `.js` files in the `src` folder:

```toml
name = "my-worker"
main = "src/index.js

find_additional_modules = true
rules = [
{ type = "ESModule", globs = ["*.js"]}
]
```

Now, a request to `http://localhost:8787/one.js` would return the contents of `src/one.js`, but a request to `http://localhost:8787/hidden/secret.js` would error with _No such module "hidden/secret.js"._ To include this file, you could expand the `rules` array to be:

```toml
rules = [
{ type = "ESModule", globs = ["**/*.js"]}
]
```

Then, a request to `http://localhost:8787/hidden/secret.js` will return the contents of `src/hidden/secret.js`.

After this update:

- Let's put the wrangler.toml back to its original configuration:

```toml
name = "my-worker"
main = "src/index.js
```

- Now, a request to `http://localhost:8787/one.js` will return the contents of `src/one.js`, but a request to `http://localhost:8787/hidden/secret.js` will ALSO return the contents of `src/hidden/secret.js`. THIS MAY NOT BE WHAT YOU WANT. You can "fix" this in 2 ways:

1. Remove the inline wildcard import:

```js
// src/index.js
export default {
async fetch() {
const name = new URL(request.url).pathname;
const moduleName = "./" + name;
const value = (await import(moduleName)).default;
return new Response(value);
},
};
```

Now, no extra modules are included in the bundle, and a request to `http://localhost:8787/hidden/secret.js` will throw an error. You can use the `find_additional_modules` feature to include it again.

2. Don't use the wildcard import pattern:

```js
// src/index.js
import one from "./one.js";
import two from "./two.js";

export default {
async fetch() {
const name = new URL(request.url).pathname;
switch (name) {
case "/one.js":
return new Response(one);
case "/two.js":
return new Response(two);
default:
return new Response("Not found", { status: 404 });
}
},
};
```

Further, there may be some files that aren't modules (js/ts/wasm/text/binary/etc) that are in the folder being included (For example, a `photo.jpg` file). This pattern will now attempt to include them in the bundle, and throw an error. It will look like this:

`[ERROR] No loader is configured for ".png" files: src/photo.jpg`

To fix this, simply move the offending file to a different folder.

In general, we DO NOT recommend using the wildcard import pattern. If done wrong, it can leak files into your bundle that you don't want, or make your worker slightly slower to start. If you must use it (either with a wildcard import pattern or with `find_additional_modules`) you must be diligent to check that your worker is working as expected and that you are not leaking files into your bundle that you don't want. You can configure eslint to disallow dynamic imports like this:

```js
// eslint.config.js
export default [
{
rules: {
"no-restricted-syntax": [
"error",
{
selector: "ImportExpression[argument.type!='Literal']",
message:
"Dynamic imports with non-literal arguments are not allowed.",
},
],
},
},
];
```
5 changes: 5 additions & 0 deletions .changeset/slimy-pumpkins-tickle.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
wrangler: major
---

Wrangler now supports the versions of Node that Node itself supports (Current, Active, Maintenance). Currently, that includes Node v18, v20, and v22.
64 changes: 64 additions & 0 deletions .github/workflows/next-prerelease.yml
Original file line number Diff line number Diff line change
@@ -0,0 +1,64 @@
name: Publish @next pre-release

on:
push:
branches:
- next
jobs:
prerelease:
timeout-minutes: 30
concurrency:
group: ${{ github.workflow }}-${{ github.ref }}
cancel-in-progress: true
if: ${{ github.repository_owner == 'cloudflare' }}
name: Build & Publish a next release to NPM
runs-on: ubuntu-22.04

steps:
- name: Checkout Repo
uses: actions/checkout@v4
with:
fetch-depth: 0

- name: Install Dependencies
uses: ./.github/actions/install-dependencies
with:
turbo-api: ${{ secrets.TURBO_API }}
turbo-team: ${{ secrets.TURBO_TEAM }}
turbo-token: ${{ secrets.TURBO_TOKEN }}
turbo-signature: ${{ secrets.TURBO_REMOTE_CACHE_SIGNATURE_KEY }}

- name: Modify package.json version
run: |
node .github/version-script.js wrangler
node .github/version-script.js miniflare

- name: Build
run: pnpm run build
env:
NODE_ENV: "production"
CI_OS: ${{ runner.os }}

- name: Check for errors
run: pnpm run check
env:
NODE_OPTIONS: "--max_old_space_size=8192"

- name: Publish wrangler@next to NPM
run: pnpm --filter wrangler publish --tag next
env:
NODE_AUTH_TOKEN: ${{ secrets.NPM_PUBLISH_TOKEN }}
# this is the "test/staging" key for sparrow analytics
SPARROW_SOURCE_KEY: "5adf183f94b3436ba78d67f506965998"
ALGOLIA_APP_ID: ${{ secrets.ALGOLIA_APP_ID }}
SENTRY_DSN: "https://[email protected]/583"
ALGOLIA_PUBLIC_KEY: ${{ secrets.ALGOLIA_PUBLIC_KEY }}

- name: Publish miniflare@next to NPM
run: pnpm --filter miniflare publish --tag next
env:
NODE_AUTH_TOKEN: ${{ secrets.NPM_PUBLISH_TOKEN }}

- name: Get Package Version
run: echo "WRANGLER_VERSION=$(npm view wrangler@next version)" >> $GITHUB_ENV
working-directory: packages/wrangler
Loading
Loading