Skip to content

[wrangler] Read workers.dev URLs from Worker resource - #15678

Open
christhorwarth wants to merge 11 commits into
cloudflare:mainfrom
christhorwarth:fix/granular-auth-workers-dev-subdomain
Open

christhorwarth wants to merge 11 commits into
cloudflare:mainfrom
christhorwarth:fix/granular-auth-workers-dev-subdomain

Conversation

@christhorwarth

@christhorwarth christhorwarth commented Sep 16, 2026

Copy link
Copy Markdown
Contributor

Fixes an internal compatibility issue with granular Worker API tokens.

Wrangler previously read the account-level workers.dev subdomain after Worker-scoped deployment operations, causing successful uploads to fail when granular tokens lacked account-level subdomain permission. Deploy and version-preview output now use subdomain.url and subdomain.preview_url_suffix from the Worker resource endpoint.

The account-level endpoint remains in the first-Worker flow only to detect and register a missing workers.dev subdomain. Existing Worker deployments no longer depend on account-level subdomain access.


  • Tests
    • Tests included/updated
    • Automated tests not possible - manual testing has been completed as follows:
    • Additional testing not necessary because:
  • Public documentation
    • Cloudflare docs PR(s):
    • Documentation not necessary because: This fixes authorization compatibility without changing configuration or documented behavior.

Note

This is a contribution from an AI agent: OpenCode, openai/gpt-5.6-sol.

@changeset-bot

changeset-bot Bot commented Sep 16, 2026

Copy link
Copy Markdown

🦋 Changeset detected

Latest commit: 769438c

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 3 packages
Name Type
wrangler Patch
@cloudflare/vite-plugin Patch
@cloudflare/vitest-plugin Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-project-automation github-project-automation Bot moved this to Untriaged in workers-sdk Sep 16, 2026
@workers-devprod
workers-devprod requested review from a team and NuroDev and removed request for a team September 16, 2026 13:58
@workers-devprod

workers-devprod commented Sep 16, 2026

Copy link
Copy Markdown
Contributor

Codeowners approval required for this PR:

  • @cloudflare/wrangler
Show detailed file reviewers
  • .changeset/tidy-mice-wave.md: [@cloudflare/wrangler]
  • packages/deploy-helpers/package.json: [@cloudflare/wrangler]
  • packages/deploy-helpers/src/deploy/helpers/validate-worker-props.ts: [@cloudflare/wrangler]
  • packages/deploy-helpers/src/deploy/versions-upload.ts: [@cloudflare/wrangler]
  • packages/deploy-helpers/src/shared/context.ts: [@cloudflare/wrangler]
  • packages/deploy-helpers/src/shared/types.ts: [@cloudflare/wrangler]
  • packages/deploy-helpers/src/triggers/deploy.ts: [@cloudflare/wrangler]
  • packages/deploy-helpers/src/triggers/subdomain.ts: [@cloudflare/wrangler]
  • packages/deploy-helpers/tests/email-routing-apply.test.ts: [@cloudflare/wrangler]
  • packages/deploy-helpers/tests/index.test.ts: [@cloudflare/wrangler]
  • packages/deploy-helpers/tests/publish-custom-domains.test.ts: [@cloudflare/wrangler]
  • packages/deploy-helpers/tests/triggers-email-routing.test.ts: [@cloudflare/wrangler]
  • packages/deploy-helpers/tests/triggers-subdomain.test.ts: [@cloudflare/wrangler]
  • packages/wrangler/src/tests/deploy/build.test.ts: [@cloudflare/wrangler]
  • packages/wrangler/src/tests/deploy/core.test.ts: [@cloudflare/wrangler]
  • packages/wrangler/src/tests/deploy/workers-dev.test.ts: [@cloudflare/wrangler]
  • packages/wrangler/src/tests/helpers/mock-workers-subdomain.ts: [@cloudflare/wrangler]
  • packages/wrangler/src/tests/versions/versions.upload.test.ts: [@cloudflare/wrangler]
  • packages/wrangler/src/tests/vitest.setup.ts: [@cloudflare/wrangler]
  • packages/wrangler/src/api/deploy-helpers-context.ts: [@cloudflare/wrangler]
  • packages/wrangler/src/api/startDevWorker/DevEnv.ts: [@cloudflare/wrangler]
  • packages/wrangler/src/core/register-yargs-command.ts: [@cloudflare/wrangler]
  • packages/wrangler/src/pages/run-workers-deploy.ts: [@cloudflare/wrangler]
  • pnpm-lock.yaml: [@cloudflare/wrangler]

@devin-ai-integration devin-ai-integration Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note

This report is out of date. Scroll down for Devin Review's latest report on this PR.

✅ Devin Review: No Issues Found

Devin Review analyzed this PR and found no bugs or issues to report.

Devin Review

@pkg-pr-new

pkg-pr-new Bot commented Sep 16, 2026

Copy link
Copy Markdown
@cloudflare/autoconfig

npm i https://pkg.pr.new/@cloudflare/autoconfig@15678

@cloudflare/build-output-utils

npm i https://pkg.pr.new/@cloudflare/build-output-utils@15678

@cloudflare/codemods

npm i https://pkg.pr.new/@cloudflare/codemods@15678

@cloudflare/config

npm i https://pkg.pr.new/@cloudflare/config@15678

@cloudflare/containers-shared

npm i https://pkg.pr.new/@cloudflare/containers-shared@15678

create-cloudflare

npm i https://pkg.pr.new/create-cloudflare@15678

@cloudflare/deploy-helpers

npm i https://pkg.pr.new/@cloudflare/deploy-helpers@15678

@cloudflare/kv-asset-handler

npm i https://pkg.pr.new/@cloudflare/kv-asset-handler@15678

miniflare

npm i https://pkg.pr.new/miniflare@15678

@cloudflare/pages-functions

npm i https://pkg.pr.new/@cloudflare/pages-functions@15678

@cloudflare/pages-shared

npm i https://pkg.pr.new/@cloudflare/pages-shared@15678

@cloudflare/unenv-preset

npm i https://pkg.pr.new/@cloudflare/unenv-preset@15678

@cloudflare/vite-plugin

npm i https://pkg.pr.new/@cloudflare/vite-plugin@15678

@cloudflare/vitest-plugin

npm i https://pkg.pr.new/@cloudflare/vitest-plugin@15678

@cloudflare/workers-auth

npm i https://pkg.pr.new/@cloudflare/workers-auth@15678

@cloudflare/workers-editor-shared

npm i https://pkg.pr.new/@cloudflare/workers-editor-shared@15678

@cloudflare/workers-utils

npm i https://pkg.pr.new/@cloudflare/workers-utils@15678

wrangler

npm i https://pkg.pr.new/wrangler@15678

commit: 769438c

@christhorwarth christhorwarth changed the title [wrangler] Tolerate unavailable workers.dev hostnames [wrangler] Read workers.dev URLs from Worker resource Sep 16, 2026
devin-ai-integration[bot]

This comment was marked as resolved.

devin-ai-integration[bot]

This comment was marked as resolved.

Comment thread packages/deploy-helpers/src/deploy/versions-upload.ts
Comment thread packages/deploy-helpers/src/triggers/subdomain.ts Outdated
Comment thread packages/deploy-helpers/src/triggers/subdomain.ts
@cjol cjol self-assigned this Sep 18, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Untriaged

Development

Successfully merging this pull request may close these issues.

4 participants