Skip to content

Use weak self captures for refcounted continuations - #7434

Open
jtolio wants to merge 1 commit into
mainfrom
jolio/use-weak-sel-6oxbqz
Open

jtolio wants to merge 1 commit into
mainfrom
jolio/use-weak-sel-6oxbqz

Conversation

@jtolio

@jtolio jtolio commented Sep 18, 2026

Copy link
Copy Markdown
Member

Eventually I hope to enable the workerd-unsafe-continuation-capture linter.

These are easy fixes where we're capturing this and this references a refcounted object. We can capture a weak pointer instead of this.

@jtolio
jtolio requested review from a team as code owners September 18, 2026 19:56
@github-actions

Copy link
Copy Markdown

The generated output of @cloudflare/workers-types has been changed by this PR. If this is intentional, run just generate-types to update the snapshot. Alternatively, you can download the full generated types:

Full Type Diff

@ask-bonk

ask-bonk Bot commented Sep 18, 2026

Copy link
Copy Markdown
Contributor

@jtolio Bonk workflow was cancelled.

View workflow run · To retry, trigger Bonk again.

@jtolio
jtolio force-pushed the jolio/use-weak-sel-6oxbqz branch from 891101d to 580c53c Compare September 18, 2026 21:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant