[nfc] Fix compiler warnings based on KJ_HEADER_WARNINGS - #7419
Merged
Merged
Conversation
npaun
reviewed
Sep 17, 2026
Contributor
|
LGTM! |
npaun
approved these changes
Sep 17, 2026
These aren't diagnosed by the compiler since they have a non-trivial destructor.
- Make a few operators const to avoid `ISO C++20 considers use of overloaded operator '==' (with operand types <type> and <type>) to be ambiguous despite there being a unique best viable function` warnings - Address `'operator==' is deprecated: Using nullptr as an empty Maybe is deprecated and will be removed. Please use kj::none for this purpose instead` warnings
This should only be needed for some tests, no need to disable it completely.
fhanau
force-pushed
the
felix/091726-build
branch
from
September 18, 2026 16:28
16d5263 to
236faf8
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We really need to ban using nullptrs with kj::Maybe instead of just deprecating it.