Skip to content

Enable debug for v8's heap.cc #7388

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
dbezhetskov wants to merge 1 commit into
base: main
Choose a base branch
from
+0 −7
Open

Enable debug for v8's heap.cc #7388

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 0 additions & 7 deletions .bazelrc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -74,13 +74,6 @@ build --cxxopt=-DKJ_WARN_REFCOUNTED_ATTACH=1
# TODO(cleanup): Causes warnings with LLVM20, fix and enable again
build --copt=-Wno-nontrivial-memaccess

# Unconditionally optimize V8 heap.cc on macOS – when optimization or inlining are disabled, this
# file appears to cause segfaults at workerd startup on macOS.
# TODO(cleanup): Investigate why this happens, our patches do not modify heap.cc itself so the bug
# might be introduced through a header included in heap.cc, through the Bazel build configuration or
# a bug in Apple LLVM.
build:macos --per_file_copt=v8/src/heap/heap.cc@-O3

# The macOS apple_support toolchain sets -DDEBUG for fastbuild, unlike the Linux toolchain. This is
# unhelpful for compile speeds and test performance, and may cause compile errors based on V8 DCHECK
# macros that reference symbols only available with V8_VERIFY_WRITE_BARRIERS (a debug-only define),
Expand Down
Loading