Add crc32 algorithm to DigestStream #3358
Merged
+497
−15
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
danlapid
commented
Jan 18, 2025
danlapid
commented
Jan 18, 2025
danlapid
commented
Jan 18, 2025
anonrig
reviewed
Jan 18, 2025
danlapid
force-pushed
the
dlapid/crc32_digeststream
branch
from
b29e9cc to
6b25145
Compare
danlapid
force-pushed
the
dlapid/crc32_digeststream
branch
from
6b25145 to
8ecaf8e
Compare
anonrig
approved these changes
Jan 20, 2025
jasnell
reviewed
Jan 20, 2025
jasnell
approved these changes
Jan 20, 2025
|
Windows is still failing to do the endian conversion for some reason. |
danlapid
force-pushed
the
dlapid/crc32_digeststream
branch
from
8ecaf8e to
4d89ed4
Compare
anonrig
reviewed
Jan 20, 2025
danlapid
force-pushed
the
dlapid/crc32_digeststream
branch
2 times, most recently
from
eddc015 to
d78071d
Compare
|
The generated output of |
fhanau
reviewed
Jan 20, 2025
danlapid
force-pushed
the
dlapid/crc32_digeststream
branch
2 times, most recently
from
927633b to
312fc25
Compare
jasnell
reviewed
Jan 20, 2025
jasnell
reviewed
Jan 20, 2025
anonrig
approved these changes
Jan 20, 2025
anonrig
reviewed
Jan 20, 2025
danlapid
force-pushed
the
dlapid/crc32_digeststream
branch
from
312fc25 to
fe6cfac
Compare
Since openssl does not support crc as a digest algorithm I extended our support through a new self implemented class and took the initial implementation out to it's own class. crc32 support is implemented using zlib's implementation. crc32c and crc64nvme are supported using our own implementation to generate the crc table at compiletime.
danlapid
force-pushed
the
dlapid/crc32_digeststream
branch
from
fe6cfac to
a10436c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since openssl does not support crc32 as a digest algorithm I extended our support through a new self implemented class and took the initial implementation out to it's own class.
Solves internal ticket #8999