Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add arm64 linux runner configurations #3356

Merged
merged 1 commit into from
Jan 20, 2025
Merged

Conversation

danlapid
Copy link
Collaborator

@danlapid danlapid commented Jan 17, 2025

This PR enables linux-arm64 runners for both every PR and every release.
We will be able to (and should) disable the internal runners finally.
This PR is missing one crucial step, merging the npm.yml and npm-types.yml workflows into the release workflow. This is split to a separate PR after we see this PR is working as expected and publishing a working linux-arm64 binary.

After both this PR and the upcoming PR is merged I have a plan to release on every merge to master thus reducing on-call load. We will add a bot that creates a daily/weekly PR to update compat-date.

@danlapid danlapid requested a review from fhanau January 17, 2025 23:56
@danlapid danlapid force-pushed the dlapid/linux_arm64_runner branch 3 times, most recently from 176e594 to d98eb83 Compare January 18, 2025 00:05
@danlapid danlapid marked this pull request as ready for review January 18, 2025 02:36
@danlapid danlapid requested review from a team as code owners January 18, 2025 02:36
@danlapid danlapid requested a review from hoodmane January 18, 2025 02:36
@danlapid danlapid force-pushed the dlapid/linux_arm64_runner branch from d98eb83 to 3539873 Compare January 18, 2025 02:38
@danlapid danlapid requested a review from mikea January 18, 2025 02:44
Copy link
Collaborator

@fhanau fhanau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, surprisingly clean! There will be some cleanup potential here (and more importantly a better developer experience) once we can add an arm64 Windows runner, likely this quarter based on GitHub's roadmap.
I highly recommend to decommission the internal arm64 runner when merging this PR, certainly before cutting another release (I don't want to find out what happens when both the internal and external jobs try to push the same release binary).

@danlapid
Copy link
Collaborator Author

LGTM, surprisingly clean! There will be some cleanup potential here (and more importantly a better developer experience) once we can add an arm64 Windows runner, likely this quarter based on GitHub's roadmap.

I highly recommend to decommission the internal arm64 runner when merging this PR, certainly before cutting another release (I don't want to find out what happens when both the internal and external jobs try to push the same release binary).

My plan was to merge this Monday, disable the internal runner and immediately cut a release
Then I'll monitor to see everything working as expected or revert.

@danlapid danlapid merged commit 00aef63 into main Jan 20, 2025
17 checks passed
@danlapid danlapid deleted the dlapid/linux_arm64_runner branch January 20, 2025 13:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants