Fixes Python SDK tests when external package loading is enabled. #3347
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hoodmane
approved these changes
Jan 16, 2025
anonrig
reviewed
Jan 17, 2025
dom96
force-pushed
the
dominik/EW-8976
branch
from
38bfd4d to
5d8a5f3
Compare
dom96
force-pushed
the
dominik/EW-8976
branch
from
5d8a5f3 to
43139f0
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some explanation of the failure here: The
internetoutbound in workerd is the one thatfetchtargets, so since we fetch packages in workerd and this test pointsfetchat a custom Python server, it goes into an infinite loop due to the Python server attempting to load packages from ... itself.Solution here is to create a JS proxy that either sends the requests onto the Python server or to the internet.