Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

01-15-25 Roll deps #3343

Merged
merged 1 commit into from
Jan 16, 2025
Merged

01-15-25 Roll deps #3343

merged 1 commit into from
Jan 16, 2025

Conversation

fhanau
Copy link
Collaborator

@fhanau fhanau commented Jan 16, 2025

  • With latest rules_rust, -Cembed-bitcode=n is set automatically if LTO is
    disabled, no need to add it manually
  • Rust crate data is no longer passed at compile time, so use compile_data
    in cxxbridge-cmd build file

Copy link

github-actions bot commented Jan 16, 2025

The generated output of @cloudflare/workers-types matches the snapshot in types/generated-snapshot 🎉

- With latest rules_rust, -Cembed-bitcode=n is set automatically if LTO is
  disabled, no need to add it manually
- Rust crate data is no longer passed at compile time, so use compile_data
  in cxxbridge-cmd build file
@fhanau fhanau force-pushed the felix/011525-roll-deps branch from 1fb2c60 to 0eb9ba2 Compare January 16, 2025 04:35
@fhanau fhanau marked this pull request as ready for review January 16, 2025 04:58
@fhanau fhanau requested review from a team as code owners January 16, 2025 04:58
@fhanau fhanau merged commit 5377f9f into main Jan 16, 2025
15 checks passed
@fhanau fhanau deleted the felix/011525-roll-deps branch January 16, 2025 16:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants