CACHE-11937: add compat flag to support cache rules overrides #3342
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
All contributors have signed the CLA ✍️ ✅ |
|
recheck |
|
@jasnell how do I sign the CLA? It doesn't give me any option here in the PR |
|
I have read the CLA Document and I hereby sign the CLA |
|
recheck |
nvm I'm so dumb, if only I had RTFM (#3342 (comment)) |
kentonv
reviewed
Jan 16, 2025
yj7o5
force-pushed
the
yawar/CACHE-11937_add-compat-flag-for-request-cf-overrides-cache-rules
branch
from
9cb199b to
0e43df7
Compare
…t-cf-overrides-cache-rules
danlapid
approved these changes
Jan 21, 2025
jasnell
approved these changes
Jan 21, 2025
|
recheck |
yj7o5
deleted the
yawar/CACHE-11937_add-compat-flag-for-request-cf-overrides-cache-rules
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding a new flag to support overriding cache rules via request.cf object. Currently, if a resource is fetched via the fetch API and have cache settings such as cacheEverything: true specified in the 'cf' object, while there is also cache rules defined against that resource, the cache settings in request cf object isn't respected. Cache team is working on fixing this behavior to give precedence over to request cf object first and then to cache rules, however, we are hiding this behavior behind a compatibility flag until we're confident the change works as intended for everyone.