refactor zlib to simplify our implementation #2679
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jasnell
approved these changes
Sep 9, 2024
anonrig
force-pushed
the
yagiz/refactor-zlib
branch
from
ac508a9 to
b9ade90
Compare
npaun
reviewed
Sep 9, 2024
Co-authored-by: Nicholas Paun <[email protected]>
npaun
approved these changes
Sep 9, 2024
npaun
requested changes
Sep 11, 2024
| @@ -338,8 +338,10 @@ class ZlibUtil final: public jsg::Object { | |||
| } | |||
|
|
|||
| protected: | |||
| CompressionContext* context() { | |||
| return &context_; | |||
| CompressionContext context; | |||
There was a problem hiding this comment.
This creates a use-after-free error because allocations will be destroyed before context.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A little bit late to the party but, I'm following up to @jasnell's comment on
context()