Fix D1 DO mock and tests #2663
Merged
Fix D1 DO mock and tests #2663
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The results format parsing changed in https://developers.cloudflare.com/d1/platform/changelog/#2024-07-26 and we always return `results`. Also, the `rows_read` value of the results has some inconsistencies between these tests (d1-mock) and our internal worker tests, off-by-one, so replacing with `anything` for now.
lambrospetrou
force-pushed
the
lambros/d1-fix-tests-with-correct-results
branch
from
eb51c66 to
2fe522f
Compare
justin-mp
approved these changes
Sep 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The results format parsing changed in https://developers.cloudflare.com/d1/platform/changelog/#2024-07-26 and we always return
results.Also, the
rows_readvalue of the results has some inconsistencies between these tests (d1-mock) and our internal worker tests, off-by-one, so replacing withanythingfor now.Testing