-
Notifications
You must be signed in to change notification settings - Fork 346
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove isBuiltIn and builtinModules #2662
Conversation
All contributors have signed the CLA ✍️ ✅ |
I have read the CLA Document and I hereby sign the CLA |
Not sure how to format the code, it would be a nice addition to CONTRIBUTING.md |
Looks you just need to run python3 ./tools/cross/format.py In the CI it runs this with |
I think we missed the window to do a revert on this. These APIs ended up getting pulled into an internal workers release yesterday that is already underweigh. |
Can we get the next?
…On Thu, Sep 5, 2024, 16:46 James M Snell ***@***.***> wrote:
I think we missed the window to do a revert on this. These APIs ended up
getting pulled into an internal workers release yesterday that is already
underweigh.
—
Reply to this email directly, view it on GitHub
<#2662 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAB4X4XAUCM4N2DAKPOAAA3ZVBVCNAVCNFSM6AAAAABNV6I36GVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDGMZRHA4TIMRYGM>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
|
Closing as these have already gone out into a release. |
Following this discussion this PR removes
.isBuiltin
and.builtinModules
./cc @jasnell @pi0 @petebacondarwin @IgorMinar