Add packages to ArtifactBundler #2618
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
anonrig
approved these changes
Aug 28, 2024
garrettgu10
force-pushed
the
ggu/packages-in-artifact-bundler
branch
2 times, most recently
from
39b9bc1 to
7c2c621
Compare
garrettgu10
force-pushed
the
ggu/packages-in-artifact-bundler
branch
from
16993cf to
e0e4782
Compare
dom96
approved these changes
Sep 5, 2024
garrettgu10
force-pushed
the
ggu/packages-in-artifact-bundler
branch
2 times, most recently
from
4d2b06e to
a8c297f
Compare
hoodmane
reviewed
Sep 10, 2024
garrettgu10
changed the title
dom96
approved these changes
Sep 10, 2024
garrettgu10
force-pushed
the
ggu/packages-in-artifact-bundler
branch
2 times, most recently
from
6ebaea9 to
57b76b5
Compare
… on the v8 isolate heap. Note that we can't just wrap the promise in an IoOwn because we don't yet have an IoContext when the promise is created
… the PackageManager. Flyby small refactor removing SmallPackagesTarReader
garrettgu10
force-pushed
the
ggu/packages-in-artifact-bundler
branch
from
6538777 to
5bf0f99
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to downstream PR 8540