[draft] Add formatting infrastructure to the project (Sort Includes). #2524
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add infrastructure to format c++ files with clang-format. We require clang-format-18 because some of the clang-format options we're using have only been released with clang-format 18. General project llvm version required remains unchanged. Added: 1. clang-format file matching internal one 2. formatting tool based on python for cross-platform 3. pre-commit and pre-push hooks for formatting validation 4. Lint CI action.
danlapid
force-pushed
the
dlapid/add-cpp-formatting-sort-includes
branch
from
e25679c to
8f7c9ec
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Similar to #2505 but adds sort includes.
Mainly opened to see if build/tests will fail when enabling this.