-
Notifications
You must be signed in to change notification settings - Fork 347
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add several node:zlib
classes
#2519
Conversation
ced872e
to
18a70ba
Compare
1a6329f
to
fff3e5c
Compare
db4fa23
to
03d8834
Compare
7870ef1
to
21868f5
Compare
fe33ab4
to
11e7e32
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good once we're sure the internal CI is green.
ff27190
to
e3fe79c
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
appreciate the effort to make all .ts code typed.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tests are failing under ASan. I'm worried there might be some kind of corruption.
Do we know why the unnecessary mutex guard caused the test failure? It doesn't immediately jump out at me what this has to do with a mutex |
Yes, the class destructor was checking the reference not the value, and causing the sanitizer to fail. |
d482047
to
e9e0856
Compare
e9e0856
to
4e9c363
Compare
Lacks tests but before adding more, I think this is getting ready to have an additional pair of eyes.
Remaining todo: