Implements setImmediate for Node.js compatibility v2 #2506
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
anonrig
reviewed
Aug 9, 2024
anonrig
approved these changes
Aug 9, 2024
kentonv
approved these changes
Aug 9, 2024
jasnell
force-pushed
the
jsnell/implement-setimmediate-for-node-compat-v2
branch
from
3397351 to
ff537e4
Compare
Also fixes a bug introduced in the build configuration that has causing node.js compat tests to get skipped
jasnell
force-pushed
the
jsnell/implement-setimmediate-for-node-compat-v2
branch
from
ff537e4 to
0ac31ef
Compare
vicb
added a commit
to dario-piotrowicz/poc-build-nextjs-app-for-cf-workers
that referenced
this pull request
Aug 29, 2024
Fixed by updating wrangler See cloudflare/workerd#2506
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also fixes a bug introduced in the build configuration that has causing node.js compat tests to get skipped