Allow startuptime to be reported when it isn't exceeded. #2500
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
danlapid
changed the title
danlapid
force-pushed
the
dlapid/EW-8620-report-correct-startuptime-from-validator
branch
2 times, most recently
from
01a05fa to
ca661ae
Compare
Hmm, you're right, that wasn't here yesterday though. Update: fixed |
danlapid
force-pushed
the
dlapid/EW-8620-report-correct-startuptime-from-validator
branch
2 times, most recently
from
2ea664b to
d14701a
Compare
dom96
reviewed
Aug 12, 2024
danlapid
force-pushed
the
dlapid/EW-8620-report-correct-startuptime-from-validator
branch
from
d14701a to
ecbb6ea
Compare
dom96
approved these changes
Aug 12, 2024
|
Marking with |
limitenforcer's enterStartup* functions now receive a reference to a OneOf an exception or a duration. Which can be populated by the elapsed duration if the limit was not exceeded.
danlapid
force-pushed
the
dlapid/EW-8620-report-correct-startuptime-from-validator
branch
from
ecbb6ea to
1ead2e9
Compare
danlapid
deleted the
dlapid/EW-8620-report-correct-startuptime-from-validator
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
LimitEnforcer's enterStartup* functions now receive a reference to a OneOf an exception or a duration.
Which can be populated by the elapsed duration if the limit was not exceeded.