Use weak refs between WebSockets in a WebSocketPair #2161
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kentonv
reviewed
May 24, 2024
jasnell
force-pushed
the
jsnell/fixup-websocket-ref-cycle
branch
2 times, most recently
from
9f2bc8f to
b896484
Compare
mikea
approved these changes
May 24, 2024
Breaks the strong ref cycle between the two WebSockets in a WebSocketPair. Aso, while at it, add a missing visitForGc impl to WebSocket to make sure the stored error, if any, is traced.
jasnell
force-pushed
the
jsnell/fixup-websocket-ref-cycle
branch
from
b896484 to
6fe51b1
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Breaks the strong ref cycle between the two WebSockets in a WebSocketPair.
Aso, while at it, add a missing visitForGc impl to WebSocket to make sure the stored error, if any, is traced.