Improve user facing error message on invalid content-length #2111
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fhanau
approved these changes
May 10, 2024
Previously an invalid content-length would result in an unhelpful "internal error" message to the user. This intercepts that error and replaces it with a more helpful message. Longer term, it would be idea to align this more with the fetch spec but for now, improving the error message is a good first step. Fixes: #2101
jasnell
force-pushed
the
jsnell/improve-invalid-content-length-error
branch
from
fbdd696 to
280c327
Compare
kentonv
reviewed
May 13, 2024
| AbortSignal::maybeCancelWrap(signal, kj::mv(KJ_ASSERT_NONNULL(nativeRequest).response)) | ||
| .catch_([](kj::Exception&& exception) -> kj::Promise<kj::HttpClient::Response> { | ||
| if (exception.getDescription().startsWith("invalid Content-Length header value")) { | ||
| return JSG_KJ_EXCEPTION(FAILED, Error, exception.getDescription()); |
There was a problem hiding this comment.
@jasnell Minor point, but JavaScript error message style is usually more formal than KJ error message style, e.g. expecting complete sentences with a capitalized first letter and terminating punctuation.
On another note, I don't think it's possible for this error to happen in production since the invalid value would never get past FL.
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously an invalid content-length would result in an unhelpful "internal error" message to the user. This intercepts that error and replaces it with a more helpful message.
Longer term, it would be idea to align this more with the fetch spec but for now, improving the error message is a good first step.
Fixes: #2101