Add Workers Ai types #2033
Merged
Add Workers Ai types #2033
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dom96
approved these changes
Apr 19, 2024
penalosa
requested changes
Apr 19, 2024
G4brym
force-pushed
the
add-ai-binding-types
branch
3 times, most recently
from
67c9f6e to
047dee7
Compare
penalosa
reviewed
Apr 22, 2024
G4brym
force-pushed
the
add-ai-binding-types
branch
5 times, most recently
from
3435b7e to
445d72e
Compare
penalosa
reviewed
Apr 23, 2024
types/defines/ai.d.ts
Outdated
| declare abstract class Ai { | ||
| private readonly fetcher; | ||
| private options; | ||
| lastRequestId: string | null; |
There was a problem hiding this comment.
Is this property intentionally public? I can't find it in the docs
penalosa
reviewed
Apr 23, 2024
types/defines/ai.d.ts
Outdated
Comment on lines
279
to
280
| private readonly fetcher; | ||
| private options; |
There was a problem hiding this comment.
This are internal implementation details that shouldn't be included
types/defines/ai.d.ts
Outdated
| private readonly fetcher; | ||
| private options; | ||
| lastRequestId: string | null; | ||
| constructor(fetcher: Fetcher); |
There was a problem hiding this comment.
This isn't user constructable, so the constructor shouldn't be included
G4brym
force-pushed
the
add-ai-binding-types
branch
from
445d72e to
d7e56df
Compare
G4brym
force-pushed
the
add-ai-binding-types
branch
from
d7e56df to
7f3789c
Compare
penalosa
approved these changes
Apr 24, 2024
9 tasks
garrettgu10
pushed a commit
that referenced
this pull request
May 13, 2024
* Add Workers Ai types * Improve ai types
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.