New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Check lower bound returned by atoi() #1603

Merged

garrettgu10 merged 1 commit into cloudflare:main from garrettgu10:ggu/atoi-lower-bound-check

Feb 1, 2024

Contributor

garrettgu10 commented Feb 1, 2024

A potential negative value returned by atoi() may cause an excessive memory allocation. This PR adds a check that the returned value is nonnegative.


          Check lower bound returned by atoi()

22d0df0

garrettgu10 requested review from a team as code owners

February 1, 2024 16:19

garrettgu10 requested review from fhanau and jp4a50

February 1, 2024 16:19

Warfields approved these changes

View reviewed changes

garrettgu10 merged commit 84dfc6f into cloudflare:main

11 checks passed

Member

kentonv commented Feb 1, 2024

We should really remove the atoi() call entirely and instead use metadata.parseAs<uint>().

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

Warfields Warfields approved these changes

fhanau Awaiting requested review from fhanau fhanau is a code owner automatically assigned from cloudflare/workers-runtime-1

jp4a50 Awaiting requested review from jp4a50 jp4a50 is a code owner automatically assigned from cloudflare/workers-runtime-1

Labels

None yet