Python: Only pass metadata that we need #1600
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Rather than serializing the entire workerd config into a JSON string and then deserializing it at runtime this makes another readonly file system so we can copy only the data that Python wants to look at. This will copy all Data, Text, and Python files once at startup into the MetadataReader since I am not sure about the lifespan of the capnp config and it seems easier to understand if we make the module own its data.
jasnell
reviewed
Feb 3, 2024
dom96
approved these changes
Feb 5, 2024
Comment on lines
+100
to
+101
| "pyodide.c++", | ||
| "pyodide/pyodide.c++", |
There was a problem hiding this comment.
These should be merged together, or the second one given a more descriptive name.
There was a problem hiding this comment.
I'll leave that to a followup. But it would also be good to merge pyodide.h and pyodide/pyodide.h
hoodmane
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rather than serializing the entire workerd config into a JSON string and then deserializing it at runtime this makes another readonly file system so we can copy only the data that Python wants to look at. This will copy all Data, Text, and Python files once at startup into the MetadataReader since I am not sure about the lifespan of the capnp config and it seems easier to understand if we make the module own its data.