Don't embed Python packages in workerd. #1580
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fhanau
approved these changes
Jan 26, 2024
dom96
force-pushed
the
dominik/unembed-python-packages-in-workerd
branch
from
1d8c348 to
f8d4b49
Compare
|
When I run this, it seems that it entirely breaks package loading in workerd. But this is probably acceptable in the short term to get the binary size down. I can manually revert this to do my tests... |
dom96
force-pushed
the
dominik/unembed-python-packages-in-workerd
branch
from
f8d4b49 to
abb41c6
Compare
|
@hoodmane can you try again? |
hoodmane
reviewed
Jan 26, 2024
|
I added an extra commit which fixes all the examples. |
jasnell
approved these changes
Jan 27, 2024
dom96
commented
Jan 29, 2024
| @@ -23,7 +23,8 @@ const config :Workerd.Config = ( | |||
| const mainWorker :Workerd.Worker = ( | |||
| modules = [ | |||
| (name = "worker", pythonModule = embed "./worker.py"), | |||
| (name = "fastapi", pythonRequirement = "fastapi"), | |||
| (name = "fastapi==0.103.2", pythonRequirement = ""), | |||
There was a problem hiding this comment.
will merge this, but I don't think we want to support version numbers and operators in here
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Just a simple way to disable embedding of Python packages only in workerd to reduce its binary size.