Merge pull request #3149 from cloudflare/yagiz/remove-unnecessary-sym…

…bolizer replace symbolizer with kj built-in
cloudflare · Nov 20, 2024 · f32706b · f32706b
2 parents 91ac4fd + 739c80c
commit f32706b
Show file tree

Hide file tree

Showing 5 changed files with 4 additions and 200 deletions.
diff --git a/build/kj_test.bzl b/build/kj_test.bzl
@@ -10,10 +10,7 @@ def kj_test(
         srcs = [src],
         deps = [
             "@capnp-cpp//src/kj:kj-test",
-        ] + select({
-            "@platforms//os:windows": [],
-            "//conditions:default": ["@workerd//src/workerd/util:symbolizer"],
-        }) + deps,
+        ] + deps,
         linkopts = select({
             "@//:use_dead_strip": ["-Wl,-dead_strip", "-Wl,-no_exported_symbols"],
             "//conditions:default": [""],

diff --git a/justfile b/justfile
@@ -7,7 +7,6 @@ default:
   @just --list
 
 pwd := `pwd`
-clang_version := "18"
 
 prepare:
   cargo install gen-compile-commands
@@ -25,14 +24,14 @@ build-asan *args="//...":
   just build {{args}} --config=asan --sandbox_debug
 
 test *args="//...":
-  bazel test {{args}} --test_env=LLVM_SYMBOLIZER=llvm-symbolizer-{{clang_version}}
+  bazel test {{args}}
 
 test-asan *args="//...":
   just test {{args}} --config=asan
 
 # e.g. just stream-test //src/cloudflare:cloudflare.capnp@eslint
 stream-test args:
-  bazel test {{args}} --test_output=streamed --test_env=LLVM_SYMBOLIZER=llvm-symbolizer-{{clang_version}}
+  bazel test {{args}} --test_output=streamed
 
 # e.g. just node-test zlib
 node-test test_name:

diff --git a/src/workerd/server/BUILD.bazel b/src/workerd/server/BUILD.bazel
@@ -57,10 +57,7 @@ wd_cc_binary(
         "//src/workerd/util:autogate",
         "//src/workerd/util:perfetto",
         "@capnp-cpp//src/capnp:capnpc",
-    ] + select({
-        "@platforms//os:windows": [],
-        "//conditions:default": ["@workerd//src/workerd/util:symbolizer"],
-    }),
+    ],
 )
 
 wd_cc_library(

diff --git a/src/workerd/util/BUILD.bazel b/src/workerd/util/BUILD.bazel
@@ -143,21 +143,6 @@ wd_cc_library(
     ],
 )
 
-wd_cc_library(
-    name = "symbolizer",
-    srcs = ["symbolizer.c++"],
-    target_compatible_with = select({
-        "@platforms//os:windows": ["@platforms//:incompatible"],
-        "//conditions:default": [],
-    }),
-    visibility = ["//visibility:public"],
-    deps = [
-        ":sentry",
-        "@capnp-cpp//src/kj",
-    ],
-    alwayslink = 1,
-)
-
 wd_cc_library(
     name = "own-util",
     hdrs = ["own-util.h"],

diff --git a/src/workerd/util/symbolizer.c++ b/src/workerd/util/symbolizer.c++