fix(ci): deploy scaffolded Cloudflare Build Output - #3527
Merged
Merged
Conversation
@vinext/cloudflare
create-vinext-app
@vinext/types
vinext
@cloudflare/workers-response-store
commit: |
Contributor
Performance benchmarksCompared 0 improved · 0 regressed · 6 within ±1.5%
View detailed results and traces 🟢 improvement · 🔴 regression · ⚫ change below 1.5% · paired base/head |
Contributor
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Both scaffold deployment workflows have failed on main since #3504 switched Cloudflare init to typed config/Build Output. They still try to read
wrangler.jsonc, aborting before the build (create-next-app failure, create-vinext-app failure). The core CI workflow remains green.Update both workflows to configure
cloudflare.config.tsand verify the generated Build Output. Preserve the deployed application names, preview URLs, KV namespace, and Response Store service identity; deploy the auxiliary service through its generateddeploy:response-storescript. Make the create-next-app data-cache choice explicit for noninteractive runs. The CI namespace override targets the KV binding call, supporting both the old placeholder and thebindings.kv()autoprovisioning form introduced in #3528.Validation:
ENOENT, and the updated steps pass.cf --dry-run.bindings.kv({ id: "<your-kv-namespace-id>" })andbindings.kv(). Both compile with the expected CI namespace, Worker name, and preview URLs, and both deployment dry runs pass.vp test run tests/init-cloudflare.test.ts tests/create-vinext-app.test.ts: 118 tests passed.vp check,actionlint,zizmor --offline, andgit diff --checkpassed.c38bcdae98c16d5f9a12ebffe176fbe7889f682b, including the KV compatibility update.These deployment workflows run only on main. Live deployment and their remote smoke tests will run after merge; local validation used dry runs.