feat(tracing): add App segment module spans - #3270
Draft
james-elicx wants to merge 1 commit into
Draft
james-elicx wants to merge 1 commit into
james-elicx wants to merge 1 commit into
Conversation
Member
Author
|
/bigbonk review for issues. You have an 8-minute time limit; report all findings within that limit. |
@vinext/cloudflare
create-vinext-app
@vinext/types
vinext
@cloudflare/workers-response-store
commit: |
Contributor
|
error: Your local changes to the following files would be overwritten by checkout: |
Contributor
|
@james-elicx Bonk workflow failed. Check the logs for details. View workflow run · To retry, trigger Bonk again. |
Contributor
|
Contributor
Performance benchmarksCompared 0 improved · 0 regressed · 6 within ±1.5%
View detailed results and traces 🟢 improvement · 🔴 regression · ⚫ change below 1.5% · paired base/head |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
NextNodeServer.createComponentTreeandNextNodeServer.getLayoutOrPageModulehierarchy through the shared framework tracer__PAGE__, route groups/dynamic segments, and named slot roots ((__SLOT__))@sentry/nextjsintegration on WorkerdNext.js parity
Pinned against
vercel/next.js@b421cadefd31c1b59d117842021ded7c1ebaf5b4, especially:packages/next/src/server/app-render/create-component-tree.tsxpackages/next/src/server/lib/app-dir-module.tspackages/next/src/server/lib/trace/constants.tstest/e2e/opentelemetry/instrumentation/opentelemetry.test.tsPresent page/layout modules emit even when their default export is invalid, while
defaultPageremains hidden exactly as in Next.js. Eagerly hydrated inactive slot modules do not create spans.No OpenTelemetry package is added as a required vinext dependency, and no Sentry-specific runtime path is introduced. The same descriptors flow to Workers tracing automatically.
Validation
vp checkvp run vinext#buildPLAYWRIGHT_PROJECT=cloudflare-sentry-app pnpm run test:e2e(17 passed)Stack parent: #3269