Skip to content

feat(cloudflare): automate Workers Response Store deployment - #3248

Closed
james-elicx wants to merge 20 commits into
mainfrom
codex/response-store-auto-deploy
Closed

james-elicx wants to merge 20 commits into
mainfrom
codex/response-store-auto-deploy

Conversation

@james-elicx

@james-elicx james-elicx commented Sep 14, 2026

Copy link
Copy Markdown
Member

Keeps caching opt-in for generated Cloudflare apps, while making Workers Response Store the default choice after users enable caching and making service-binding mode a one-command deployment.\n\n- generates a private Response Store Worker, R2 binding, SQLite Durable Object migration, app service binding, and version metadata\n- deploys the generated cache Worker before the application through vinext-cloudflare deploy\n- supports stable custom service and R2 names, plus binding a separately managed compatible service\n- adds an explicit cache opt-in to vinext init and create-vinext-app, with Response Store preselected\n- migrates apps/web from Workers Cache plus KV to its own vinext-web-response-store\n- exercises generated service artifacts in local E2E and deployment CI\n\nValidation:\n- 490 focused unit tests\n- 30 @vinext/cloudflare tests, including service-binding and self-contained E2E\n- targeted format, lint, and type checks\n- actionlint for modified deployment workflows\n- response-store-demo live one-command deployment with service, R2, and Durable Object reuse\n- apps/web production build plus Wrangler dry-runs for both generated Workers

@pkg-pr-new

pkg-pr-new Bot commented Sep 14, 2026

Copy link
Copy Markdown

Open in StackBlitz

@vinext/cloudflare

npm i https://pkg.pr.new/cloudflare/vinext/@vinext/cloudflare@3248

create-vinext-app

npm i https://pkg.pr.new/cloudflare/vinext/create-vinext-app@3248

@vinext/types

npm i https://pkg.pr.new/cloudflare/vinext/@vinext/types@3248

vinext

npm i https://pkg.pr.new/cloudflare/vinext@3248

@cloudflare/workers-response-store

npm i https://pkg.pr.new/cloudflare/vinext/@cloudflare/workers-response-store@3248

commit: 9007bce

@github-actions

Copy link
Copy Markdown
Contributor
Example Preview Production Original
app-router-cloudflare preview production
pages-router-cloudflare preview production
app-router-playground preview production original
realworld-api-rest preview production
nextra-docs-template preview production
benchmarks preview production
hackernews preview production original
response-store-demo preview production
static-export preview production
web preview production

@github-actions

github-actions Bot commented Sep 14, 2026

Copy link
Copy Markdown
Contributor

Performance benchmarks

Compared 9007bce against base 8eccc20 using alternating same-runner rounds. Next.js was unchanged and skipped.

0 improved · 0 regressed · 6 within ±1.5%

Scenario Framework Baseline Current Change
Client bundle size (gzip) vinext 142.3 KB 142.2 KB ⚫ -0.0%
Client entry size (gzip) vinext 129.6 KB 129.6 KB ⚫ -0.0%
Dev server cold start vinext 3.85 s 3.86 s ⚫ +0.4%
Production build time vinext 3.84 s 3.80 s ⚫ -0.9%
RSC entry closure size (gzip) vinext 125.8 KB 125.8 KB ⚫ +0.0%
Server bundle size (gzip) vinext 216.5 KB 216.5 KB ⚫ +0.0%

View detailed results and traces

🟢 improvement · 🔴 regression · ⚫ change below 1.5% · paired base/head

@james-elicx

Copy link
Copy Markdown
Member Author

/bigbonk review for issues

@james-elicx

Copy link
Copy Markdown
Member Author

/bigbonk review for issues

@james-elicx

Copy link
Copy Markdown
Member Author

/bigbonk review for issues

@ask-bonk

ask-bonk Bot commented Sep 14, 2026

Copy link
Copy Markdown
Contributor

@james-elicx Bonk workflow was cancelled.

View workflow run · To retry, trigger Bonk again.

@james-elicx

Copy link
Copy Markdown
Member Author

/bigbonk review for in-scope correctness bugs only. You have an 8 minute time limit; finish and post your findings within 8 minutes.

Comment thread packages/vinext/src/init-platform.ts
Comment thread .github/workflows/deploy-examples.yml
@ask-bonk

ask-bonk Bot commented Sep 14, 2026

Copy link
Copy Markdown
Contributor

Posted 2 inline correctness findings.

github run

@james-elicx

Copy link
Copy Markdown
Member Author

/bigbonk review for in-scope correctness bugs only. You have an 8 minute time limit; finish and post your findings within 8 minutes.

Comment thread packages/vinext/src/init-cloudflare.ts
Comment thread packages/cloudflare/src/cache/response-store-adapter-config.ts Outdated
@ask-bonk

ask-bonk Bot commented Sep 14, 2026

Copy link
Copy Markdown
Contributor

Posted 2 inline correctness findings.

github run

@james-elicx

Copy link
Copy Markdown
Member Author

/bigbonk review for in-scope correctness bugs only. Review the latest head 7e547a5. You have an 8 minute time limit; finish and post your findings within 8 minutes.

@james-elicx
james-elicx marked this pull request as ready for review September 14, 2026 12:02
Comment thread packages/vinext/src/init-cloudflare.ts Outdated
@ask-bonk

ask-bonk Bot commented Sep 14, 2026

Copy link
Copy Markdown
Contributor

Posted 1 inline correctness finding.

github run

@james-elicx

Copy link
Copy Markdown
Member Author

/bigbonk review for in-scope correctness bugs only. Review the latest head 0394a5f. You have an 8 minute time limit; finish and post your findings within 8 minutes.

Comment thread packages/vinext/src/init-cloudflare.ts Outdated
Comment thread packages/vinext/src/init-cloudflare.ts
Comment thread packages/cloudflare/src/deploy.ts Outdated
Comment thread packages/cloudflare/src/cache/response-store-adapter-config.ts
@ask-bonk

ask-bonk Bot commented Sep 14, 2026

Copy link
Copy Markdown
Contributor

Posted 4 inline correctness findings.

github run

@james-elicx

Copy link
Copy Markdown
Member Author

/bigbonk review for in-scope correctness bugs only. Review latest head 9183dd7. Hard 8 minute time limit: stop analysis and post your findings before 8 minutes elapse.

Comment thread packages/vinext/src/init-platform.ts
Comment thread packages/vinext/src/init-cloudflare.ts Outdated
@ask-bonk

ask-bonk Bot commented Sep 14, 2026

Copy link
Copy Markdown
Contributor

Posted 2 inline correctness findings.

github run

@james-elicx

Copy link
Copy Markdown
Member Author

/bigbonk review for in-scope correctness bugs only. Review latest head 2ab45b6. Hard 8 minute time limit: stop analysis and post your findings before 8 minutes elapse.

Comment thread packages/cloudflare/src/deploy.ts Outdated
Comment thread packages/cloudflare/src/cache/response-store-adapter-config.ts Outdated
@ask-bonk

ask-bonk Bot commented Sep 14, 2026

Copy link
Copy Markdown
Contributor

Posted 2 inline correctness findings. Targeted tests passed: 368 tests.

github run

@james-elicx

Copy link
Copy Markdown
Member Author

/bigbonk re-review only the fixes for your prior comments in commit 28619f5 (authoritative deploy redirect and bounded self-contained bucket naming). Do not review the CI-only test change in a3aef5d. Hard 8 minute time limit: stop analysis and post findings before 8 minutes elapse.

Comment thread packages/cloudflare/src/deploy.ts Outdated
Comment thread packages/cloudflare/src/cache/response-store-adapter-config.ts
@ask-bonk

ask-bonk Bot commented Sep 14, 2026

Copy link
Copy Markdown
Contributor

Posted 2 inline correctness findings. Targeted tests passed: 370 tests.

github run

@james-elicx

Copy link
Copy Markdown
Member Author

/bigbonk re-review only the fixes for your prior comments in commit 7666376. Do not review the CI-only test commits. Hard 8 minute time limit: stop analysis and post findings before 8 minutes elapse.

@ask-bonk

ask-bonk Bot commented Sep 14, 2026

Copy link
Copy Markdown
Contributor

LGTM!

github run

@james-elicx

Copy link
Copy Markdown
Member Author

Superseded by #3249, which implements the config-first design from a clean branch.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant