fix(test): pin React in deploy suite fixtures - #3229
Merged
Conversation
Member
Author
|
/bigbonk review for issues |
commit: |
Contributor
|
Contributor
Performance benchmarksCompared 0 improved · 0 regressed · 6 within ±1.5%
View detailed results and traces 🟢 improvement · 🔴 regression · ⚫ change below 1.5% · paired base/head |
Contributor
|
LGTM! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
react,react-dom, andreact-server-dom-webpackin throwaway App Router deploy fixtures to the exact versions from the frozen vinext workspace installnext-dynamic-csp-noncepreload assertion as requiring the existing Vite/Cloudflare equivalentRegression analysis
The deploy suite moved from 2,688 passed / 116 failed / 631 skipped in run 34301853704 to 2,674 / 130 / 631 in run 34428108977.
A same-head rerun reproduced 13 pass-to-fail assertions. Twelve were production RSC error-message/recovery assertions: the deploy harness creates lockfile-free apps from open React peer ranges, so the publication of
react-server-dom-webpack@19.3.0changed the installed runtime independently of vinext and replaced the prior production error with minified React error #441. Re-running the older vinext SHA against today's registry reproduced that failure, confirming dependency drift rather than a vinext source regression.The remaining persistent assertion expects Next.js/webpack's
rel=preloadshape. Vinext intentionally emitsmodulepreloadfor Vite ES-module chunks to avoid duplicate downloads, and the CSP nonce is covered bytests/e2e/cloudflare-workers/dynamic-preload.spec.ts. One additional i18n failure did not reproduce and was a flake.Validation
vp test run tests/e2e-deploy-script.test.ts tests/compatibility-support.test.ts(14 passed)vp check tests/e2e-deploy-script.test.ts apps/web/app/compatibility/suite-support.ts tests/compatibility-support.test.tsbash -n scripts/e2e-deploy.shgit diff --check