Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add docs around absolute paths #1240

Merged
merged 1 commit into from
Jan 3, 2025
Merged

Add docs around absolute paths #1240

merged 1 commit into from
Jan 3, 2025

Conversation

prymitive
Copy link
Collaborator

No description provided.

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This pull request was validated by pint.

✔️ No problems found

Stats

Stat Value
Version v0.69.1-27-g29ed4c2
Number of rules parsed 4
Number of rules checked 4
Number of problems found 0
Number of offline checks 0
Number of online checks 0
Checks duration 0

Problems

No problems reported

@prymitive prymitive force-pushed the paths branch 2 times, most recently from 4858596 to 8528bdb Compare January 3, 2025 13:03
Copy link

github-actions bot commented Jan 3, 2025

Benchmark diff:

goos: linux
goarch: amd64
pkg: github.com/cloudflare/pint/cmd/pint
cpu: AMD EPYC 7763 64-Core Processor                
              │   old.txt   │              new.txt               │
              │   sec/op    │   sec/op     vs base               │
FindEntries-4   39.50m ± 3%   40.67m ± 3%  +2.96% (p=0.002 n=10)
CheckRules-4     8.496 ± 2%    8.508 ± 2%       ~ (p=0.739 n=10)
geomean         579.3m        588.2m       +1.54%

              │   old.txt    │               new.txt               │
              │     B/op     │     B/op      vs base               │
FindEntries-4   27.40Mi ± 0%   27.40Mi ± 0%       ~ (p=0.853 n=10)
CheckRules-4    977.7Mi ± 0%   977.3Mi ± 0%       ~ (p=0.631 n=10)
geomean         163.7Mi        163.6Mi       -0.03%

              │   old.txt   │              new.txt               │
              │  allocs/op  │  allocs/op   vs base               │
FindEntries-4   131.7k ± 0%   131.7k ± 0%       ~ (p=0.096 n=10)
CheckRules-4    14.15M ± 0%   14.15M ± 0%       ~ (p=0.190 n=10)
geomean         1.365M        1.365M       -0.01%

@codecov-commenter
Copy link

codecov-commenter commented Jan 3, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 95.07%. Comparing base (556ecc4) to head (29ed4c2).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1240   +/-   ##
=======================================
  Coverage   95.07%   95.07%           
=======================================
  Files         105      105           
  Lines       12638    12644    +6     
=======================================
+ Hits        12015    12021    +6     
  Misses        473      473           
  Partials      150      150           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@prymitive prymitive merged commit 1f8f627 into main Jan 3, 2025
20 checks passed
@prymitive prymitive deleted the paths branch January 3, 2025 13:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants