Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Validate file/owner comments even if there are no rules #1223

Merged
merged 1 commit into from
Dec 10, 2024
Merged

Conversation

prymitive
Copy link
Collaborator

No description provided.

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This pull request was validated by pint.

✔️ No problems found

Stats

Stat Value
Version v0.69.0-5-g02147c6
Number of rules parsed 4
Number of rules checked 4
Number of problems found 0
Number of offline checks 0
Number of online checks 0
Checks duration 0

Problems

No problems reported

Copy link

github-actions bot commented Dec 10, 2024

Benchmark diff:

goos: linux
goarch: amd64
pkg: github.com/cloudflare/pint/cmd/pint
cpu: AMD EPYC 7763 64-Core Processor                
              │   old.txt   │              new.txt               │
              │   sec/op    │   sec/op     vs base               │
FindEntries-4   38.98m ± 3%   39.19m ± 6%       ~ (p=0.143 n=10)
CheckRules-4     8.496 ± 2%    8.511 ± 2%       ~ (p=0.436 n=10)
geomean         575.5m        577.6m       +0.37%

              │   old.txt    │               new.txt               │
              │     B/op     │     B/op      vs base               │
FindEntries-4   27.40Mi ± 0%   27.40Mi ± 0%       ~ (p=0.912 n=10)
CheckRules-4    977.1Mi ± 0%   976.6Mi ± 0%       ~ (p=0.353 n=10)
geomean         163.6Mi        163.6Mi       -0.03%

              │   old.txt   │              new.txt               │
              │  allocs/op  │  allocs/op   vs base               │
FindEntries-4   131.7k ± 0%   131.7k ± 0%       ~ (p=0.644 n=10)
CheckRules-4    14.15M ± 0%   14.15M ± 0%       ~ (p=0.280 n=10)
geomean         1.365M        1.365M       -0.01%

@prymitive prymitive force-pushed the file/owner branch 2 times, most recently from 1aedcea to 6d1c163 Compare December 10, 2024 11:58
@codecov-commenter
Copy link

codecov-commenter commented Dec 10, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 95.09%. Comparing base (0979306) to head (02147c6).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1223      +/-   ##
==========================================
+ Coverage   95.07%   95.09%   +0.01%     
==========================================
  Files         105      105              
  Lines       12587    12637      +50     
==========================================
+ Hits        11967    12017      +50     
  Misses        471      471              
  Partials      149      149              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@prymitive prymitive merged commit 11f0788 into main Dec 10, 2024
20 checks passed
@prymitive prymitive deleted the file/owner branch December 10, 2024 12:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants