Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use label source for more checks #1207

Merged
merged 1 commit into from
Nov 28, 2024
Merged

Use label source for more checks #1207

merged 1 commit into from
Nov 28, 2024

Conversation

prymitive
Copy link
Collaborator

No description provided.

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This pull request was validated by pint.

✔️ No problems found

Stats

Stat Value
Version v0.67.3-48-g43111f1
Number of rules parsed 4
Number of rules checked 4
Number of problems found 0
Number of offline checks 0
Number of online checks 0
Checks duration 0

Problems

No problems reported

Copy link

github-actions bot commented Nov 28, 2024

Benchmark diff:

goos: linux
goarch: amd64
pkg: github.com/cloudflare/pint/cmd/pint
cpu: AMD EPYC 7763 64-Core Processor                
              │   old.txt   │              new.txt               │
              │   sec/op    │   sec/op     vs base               │
FindEntries-4   39.65m ± 1%   39.56m ± 3%       ~ (p=0.971 n=10)
CheckRules-4     8.513 ± 2%    8.491 ± 2%       ~ (p=0.579 n=10)
geomean         581.0m        579.6m       -0.25%

              │   old.txt    │               new.txt               │
              │     B/op     │     B/op      vs base               │
FindEntries-4   27.40Mi ± 0%   27.40Mi ± 0%       ~ (p=0.315 n=10)
CheckRules-4    976.9Mi ± 0%   977.2Mi ± 0%       ~ (p=0.579 n=10)
geomean         163.6Mi        163.6Mi       +0.01%

              │   old.txt   │              new.txt               │
              │  allocs/op  │  allocs/op   vs base               │
FindEntries-4   131.7k ± 0%   131.7k ± 0%       ~ (p=0.097 n=10)
CheckRules-4    14.15M ± 0%   14.15M ± 0%       ~ (p=0.315 n=10)
geomean         1.365M        1.365M       +0.01%

@codecov-commenter
Copy link

codecov-commenter commented Nov 28, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 94.98%. Comparing base (aeb0788) to head (43111f1).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1207   +/-   ##
=======================================
  Coverage   94.98%   94.98%           
=======================================
  Files         103      102    -1     
  Lines       12530    12455   -75     
=======================================
- Hits        11901    11830   -71     
+ Misses        479      475    -4     
  Partials      150      150           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@prymitive prymitive merged commit 2a74f5b into main Nov 28, 2024
20 checks passed
@prymitive prymitive deleted the rate branch November 28, 2024 14:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants