Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Warn about topk, bottomk and other sampling functions #1157

Merged
merged 1 commit into from
Oct 22, 2024
Merged

Conversation

prymitive
Copy link
Collaborator

Fixes #820.

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This pull request was validated by pint.

✔️ No problems found

Stats

Stat Value
Version v0.66.1-34-gb4490ca
Number of rules parsed 4
Number of rules checked 4
Number of problems found 0
Number of offline checks 0
Number of online checks 0
Checks duration 0

Problems

No problems reported

Copy link

github-actions bot commented Oct 22, 2024

Benchmark diff:

goos: linux
goarch: amd64
pkg: github.com/cloudflare/pint/cmd/pint
cpu: AMD EPYC 7763 64-Core Processor                
              │   old.txt   │              new.txt               │
              │   sec/op    │   sec/op     vs base               │
FindEntries-4   39.28m ± 2%   39.37m ± 3%       ~ (p=0.631 n=10)
CheckRules-4     8.519 ± 2%    8.526 ± 2%       ~ (p=0.579 n=10)
geomean         578.4m        579.4m       +0.16%

              │   old.txt    │               new.txt               │
              │     B/op     │     B/op      vs base               │
FindEntries-4   27.41Mi ± 0%   27.41Mi ± 0%       ~ (p=0.190 n=10)
CheckRules-4    977.7Mi ± 0%   977.6Mi ± 0%       ~ (p=0.971 n=10)
geomean         163.7Mi        163.7Mi       -0.01%

              │   old.txt   │              new.txt               │
              │  allocs/op  │  allocs/op   vs base               │
FindEntries-4   131.9k ± 0%   131.9k ± 0%       ~ (p=0.190 n=10)
CheckRules-4    14.19M ± 0%   14.19M ± 0%       ~ (p=0.739 n=10)
geomean         1.368M        1.368M       -0.00%

@codecov-commenter
Copy link

codecov-commenter commented Oct 22, 2024

Codecov Report

Attention: Patch coverage is 98.84393% with 2 lines in your changes missing coverage. Please review.

Project coverage is 94.78%. Comparing base (8856982) to head (b4490ca).

Files with missing lines Patch % Lines
internal/parser/utils/source.go 98.59% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1157      +/-   ##
==========================================
+ Coverage   94.73%   94.78%   +0.04%     
==========================================
  Files         103      104       +1     
  Lines       12110    12258     +148     
==========================================
+ Hits        11473    11619     +146     
- Misses        485      487       +2     
  Partials      152      152              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@prymitive prymitive merged commit fc1bfd5 into main Oct 22, 2024
20 checks passed
@prymitive prymitive deleted the labelSouce branch October 22, 2024 16:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add pint check to disallow topk or bottomk in recording rules
2 participants