Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix and update quick start dependency section #495

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Fix and update quick start dependency section #495

wants to merge 1 commit into from

Conversation

Voklen
Copy link

@Voklen Voklen commented Dec 18, 2024

This PR does three things:

  1. Fixes a typo for Cargo.toml and correctly formats the snippet
  2. Upgrades to pingora 0.4 (which I have tested with the quick start code and it still works as far as I can tell)
  3. Added the openssl feature, this is so that after following the quickstart guide and opening http://localhost:6188 it will work with TLS and display the one.one.one.one page

@Noah-Kennedy Noah-Kennedy self-requested a review December 20, 2024 17:24
@Noah-Kennedy Noah-Kennedy added Accepted This change is accepted by us and merged to our internal repo documentation Improvements or additions to documentation labels Dec 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Noah-Kennedy Noah-Kennedy Awaiting requested review from Noah-Kennedy

At least 2 approving reviews are required to merge this pull request.

Assignees

@Noah-Kennedy Noah-Kennedy

Labels
Accepted This change is accepted by us and merged to our internal repo documentation Improvements or additions to documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Voklen @Noah-Kennedy