Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make LocalNameHash smaller #253

Merged
merged 2 commits into from
Dec 30, 2024
Merged

Make LocalNameHash smaller #253

merged 2 commits into from
Dec 30, 2024

Conversation

kornelski
Copy link
Contributor

It's a bit ironic that LocalNameHash tries so hard to compress 12-byte names into 64 bits, but Option<u64> makes it 16 bytes large.

I've changed Option to -1 to keep it 64-bit.

@kornelski
Copy link
Contributor Author

Since the hash is reversible, I've also added a useful Debug impl for it.

@kornelski kornelski merged commit 82e4708 into master Dec 30, 2024
5 checks passed
@kornelski kornelski deleted the local-u64 branch December 30, 2024 12:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@orium orium orium approved these changes

@scotchmist scotchmist scotchmist approved these changes

@jongiddy jongiddy Awaiting requested review from jongiddy jongiddy is a code owner

@Noah-Kennedy Noah-Kennedy Awaiting requested review from Noah-Kennedy Noah-Kennedy is a code owner

@jasnell jasnell Awaiting requested review from jasnell jasnell is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@kornelski @scotchmist @orium