[RFC] Partially update selectors #250
Open
+32
−21
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This finally resolves the dependency on phf 0.8. - Port to_unconditional from selectors – this is no longer implemented for ParsedCaseSensitivity. - Add PhantomData to ExtraMatchingData which now requires a lifetime. - Add unsupported Has(_) type
fhanau
requested review from
jongiddy,
Noah-Kennedy,
orium,
scotchmist,
jasnell and
a team
as code owners
|
Unfortunately git dependencies can't be published to crates.io, so we will have to do a full upgrade. I've also started the upgrade: https://github.com/cloudflare/lol-html/compare/selectors%2Dupgrade |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm delighted that we bumped the cssparser and selectors versions in #248 after they had been stuck for a while.
For workerd, updating these packages further is desirable as it would allow us to get rid of some old crates – notably phf 0.8, which is now 5 years old and pulls in more outdated packages. I tried to update to selectors 0.25/cssparser 0.31, with some success – I was able to get the build to work but am not sure how to fix the test cases after some selectors types were added/removed (see felix/selectors-update).
To make at least some progress here, we could update to a specific commit instead. This would be sufficient to move phf forward but require fewer lol-html changes. At the same time, a given commit might be less stable than a tagged release version. Let me know what you think about updating this further – if this approach feels sensible, or if moving directly to selectors 0.25 is feasible. I hope this doesn't duplicates any work you have already been doing.
Relevant selectors commits:
to_unconditional: servo/stylo@8c33b56
ExtraMatchingData: servo/stylo@767bc8b
Has: servo/stylo@789476f