Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add CPU offload server #759

Merged
merged 2 commits into from
Jan 15, 2025
Merged

Add CPU offload server #759

merged 2 commits into from
Jan 15, 2025

Conversation

mendess
Copy link
Collaborator

@mendess mendess commented Jan 10, 2025

No description provided.

@mendess mendess self-assigned this Jan 10, 2025
@mendess mendess force-pushed the mendess/async-helper-pt2 branch from 095f6fc to 799fa2f Compare January 10, 2025 14:59
@mendess mendess force-pushed the mendess/agg-job-counting branch from d65f840 to 6e576ff Compare January 10, 2025 15:00
@mendess mendess force-pushed the mendess/async-helper-pt2 branch 3 times, most recently from 18f42b7 to 004dd73 Compare January 10, 2025 17:46
Base automatically changed from mendess/agg-job-counting to main January 13, 2025 09:19
cjpatton
cjpatton approved these changes Jan 13, 2025
View reviewed changes
Copy link
Contributor

@cjpatton cjpatton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, just some superficial comments.

crates/daphne-server/src/roles/helper.rs Outdated Show resolved Hide resolved
crates/daphne-service-utils/src/compute_offload/compute_offload.capnp Outdated Show resolved Hide resolved
crates/daphne-service-utils/src/compute_offload/mod.rs Show resolved Hide resolved
crates/daphne-service-utils/src/compute_offload/mod.rs Show resolved Hide resolved
crates/daphne-service-utils/src/compute_offload/mod.rs Outdated Show resolved Hide resolved
crates/daphne/src/messages/request.rs Outdated Show resolved Hide resolved
crates/daphne/src/messages/request.rs Outdated Show resolved Hide resolved
crates/daphne/src/roles/helper/handle_agg_job.rs Outdated Show resolved Hide resolved
crates/daphne/src/roles/helper/mod.rs Outdated Show resolved Hide resolved
crates/daphne/src/roles/helper/mod.rs Outdated Show resolved Hide resolved
@mendess mendess force-pushed the mendess/async-helper-pt2 branch 5 times, most recently from 040b1ba to ab85fa3 Compare January 14, 2025 17:46
@mendess mendess force-pushed the mendess/async-helper-pt2 branch from ab85fa3 to ac0e18c Compare January 15, 2025 10:48
@mendess mendess merged commit b01c4e4 into main Jan 15, 2025
4 checks passed
@mendess mendess deleted the mendess/async-helper-pt2 branch January 15, 2025 14:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cjpatton cjpatton cjpatton approved these changes

@armfazh armfazh Awaiting requested review from armfazh armfazh is a code owner

@bhalleycf bhalleycf Awaiting requested review from bhalleycf bhalleycf is a code owner

@fisherdarling fisherdarling Awaiting requested review from fisherdarling fisherdarling is a code owner

@cbranch cbranch Awaiting requested review from cbranch cbranch is a code owner

@lbaquerofierro lbaquerofierro Awaiting requested review from lbaquerofierro lbaquerofierro is a code owner

@RageKnify RageKnify Awaiting requested review from RageKnify RageKnify is a code owner

@jhoyla jhoyla Awaiting requested review from jhoyla jhoyla is a code owner

Assignees

@mendess mendess

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mendess @cjpatton