Bump the version of VDAF used to v13 #734
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cjpatton
reviewed
Dec 9, 2024
There was a problem hiding this comment.
This actually isn't too bad. There are some places where macros might help with de-duplication. When @mendess has a look, he might have some ideas.
Once you make the following changes, please mark as ready for review:
- Please rebase the PR.
- I commented on a few modules where I think you can probably use the latest version of
priorather than the old one. In fact, I'm fairly certain the only place you can't ispine. Please use the latest version wherever possible. - Naming convention: When there are two versions of a type, we generally follow the convention that the latest version gets the "normal" name and the old version gets a distinguished name. E.g.,
thingandthing_draft09rather thanthing_latestandthing. This makes it easier to eventually remove the old version.
jhoyla
force-pushed
the
jhoyla/bump-vdaf
branch
from
a459596 to
752c915
Compare
cjpatton
reviewed
Dec 12, 2024
cjpatton
reviewed
Dec 12, 2024
jhoyla
force-pushed
the
jhoyla/bump-vdaf
branch
2 times, most recently
from
032f242 to
98b9f63
Compare
jhoyla
requested review from
armfazh,
bhalleycf,
fisherdarling,
cbranch,
lbaquerofierro,
mendess,
Noah-Kennedy and
RageKnify
as code owners
jhoyla
force-pushed
the
jhoyla/bump-vdaf
branch
from
8930511 to
1dba666
Compare
jhoyla
force-pushed
the
jhoyla/bump-vdaf
branch
from
0fa76d2 to
b821cc6
Compare
mendess
requested changes
Dec 17, 2024
jhoyla
force-pushed
the
jhoyla/bump-vdaf
branch
from
b821cc6 to
95c55f8
Compare
jhoyla
force-pushed
the
jhoyla/bump-vdaf
branch
from
95c55f8 to
9817329
Compare
jhoyla
force-pushed
the
jhoyla/bump-vdaf
branch
from
9817329 to
990ac58
Compare
cjpatton
approved these changes
Dec 17, 2024
There was a problem hiding this comment.
One last minor comment. Note that I've tacked on a couple of commits using macros to de-duplicate some code.
Before merging:
- Looks like you'll need to rebase.
- Please squash all commits into one.
- Make sure @mendess approves. This is a big enough change that we should have a couple of eyes on it.
jhoyla
force-pushed
the
jhoyla/bump-vdaf
branch
from
0e0a19d to
a32fc63
Compare
mendess
approved these changes
Dec 18, 2024
jhoyla
force-pushed
the
jhoyla/bump-vdaf
branch
from
a32fc63 to
afc7d12
Compare
jhoyla
force-pushed
the
jhoyla/bump-vdaf
branch
from
afc7d12 to
00e2334
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.