Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove per-task HPKE config #732

Merged
merged 1 commit into from
Dec 2, 2024
Merged

Remove per-task HPKE config #732

merged 1 commit into from
Dec 2, 2024

Conversation

jhoyla
Copy link
Contributor

@jhoyla jhoyla commented Dec 2, 2024

In draft-12 per-task HPKE configs were removed. The aggregator can simply return a list of configs in preference order.

Copy link
Collaborator

@mendess mendess left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Please leave a TODO(draft09) in the DapAggregator::get_hpke_config_for to remove the task_id parameter

@jhoyla jhoyla force-pushed the jhoyla/remove-per-task-hpke branch from 2c9266a to 8f3150b Compare December 2, 2024 11:55
@jhoyla jhoyla requested a review from mendess December 2, 2024 11:56
@jhoyla jhoyla merged commit e27420f into main Dec 2, 2024
3 checks passed
@jhoyla jhoyla deleted the jhoyla/remove-per-task-hpke branch December 2, 2024 13:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants